You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:07:18 UTC
[GitHub] [airflow] Cabeda opened a new pull request #16947: Add Talkdesk as a user of airflow π
Cabeda opened a new pull request #16947:
URL: https://github.com/apache/airflow/pull/16947
As explained in the title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878599799
> Do I need to be aware of anything else beside pre-commit?
I think you get the message automatically from the bot when you submitted it - starting from "Here are some useful points:" (pre-commit was first on the list) :) - just follow what's written there. I do not want to repeat it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16947:
URL: https://github.com/apache/airflow/pull/16947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878412533
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878599799
> Do I need to be aware of anything else beside pre-commit?
I think you get the message automatically from the bit when you submitted it - starting from "Here are some useful points:" (pre-commit was first on the list) :) - just follow what's written there. I do not want to repeat it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Cabeda commented on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
Cabeda commented on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878581328
@potiuk just fixed it! Thanks for the tip!
Do I need to be aware of anything else beside pre-commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878620288
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16947: Add Talkdesk as a user of airflow π
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16947:
URL: https://github.com/apache/airflow/pull/16947#issuecomment-878533525
I think it will fail as it is not sorted propely @Cabeda (I recommend installing pre-commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org