[GitHub] [spark] yoda-mon commented on a change in pull request #34027: [SPARK-36778][SQL] Support ILIKE API on Scala(dataframe)

[GitBox <gi...@apache.org>]

yoda-mon commented on a change in pull request #34027:
URL: https://github.com/apache/spark/pull/34027#discussion_r710704819



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -846,6 +846,17 @@ class Column(val expr: Expression) extends Logging {
    */
   def rlike(literal: String): Column = withExpr { RLike(expr, lit(literal).expr) }
 
+  /**
+   * SQL ILIKE expression (case insensitive LIKE).
+   *
+   * @group expr_ops
+   * @since 3.3.0
+   */
+  def ilike(literal: String, escapeChar: Char = '\\'): Column = withExpr {

Review comment:
       I think so too, but I'd like to confirm that from SQL, it seems we can use `escapeChar`.
   https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala#L231
   Is that OK to close `escapeChar` on dataframe ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org