You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by dvjyothsna <gi...@git.apache.org> on 2018/03/12 23:46:59 UTC

[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

GitHub user dvjyothsna opened a pull request:

    https://github.com/apache/drill/pull/1162

    DRILL-6005: Fixed TestGracefulShutdown tests to skip check for loopba…

    …ck address usage in distributed mode

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dvjyothsna/drill DRILL-6005

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1162
    
----
commit 38cf91bfd3b24ed458d8519129001632ad940048
Author: dvjyothsna <jy...@...>
Date:   2018-03-12T22:38:13Z

    DRILL-6005: Fixed TestGracefulShutdown tests to skip check for loopback address usage in distributed mode

----


---

[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1162


---

[GitHub] drill issue #1162: DRILL-6005: Fixed TestGracefulShutdown tests to skip chec...

Posted by dvjyothsna <gi...@git.apache.org>.
Github user dvjyothsna commented on the issue:

    https://github.com/apache/drill/pull/1162
  
    @arina-ielchiieva Please review..Thank you 


---

[GitHub] drill issue #1162: DRILL-6005: Fixed TestGracefulShutdown tests to skip chec...

Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1162
  
    +1, thanks for making the changes.


---

[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1162#discussion_r174035415
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -640,4 +640,6 @@ public static String bootDefaultFor(String name) {
     
       public static final String DRILL_PORT_HUNT = "drill.exec.port_hunt";
     
    +  public static final String ALLOW_LOOPBACK_ADDRESS_BINDING = "drill.exec.enable_loopback_address_binding";
    --- End diff --
    
    Please rename to `drill.exec.allow_loopback_address_binding`.


---