You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/01/16 23:14:22 UTC
[kudu-CR] [catalog manager] more info if unable to replace a replica
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9040
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
[catalog_manager] more info if unable to replace a replica
Output actionable warning message when the catalog manager is unable
to find a place for a replacement replica. Since the 3-4-3 replication
scheme is now enabled by default, this might be useful in case if
running a cluster with just 3 tablet servers when tables have
replication factor of 3.
Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
3 files changed, 36 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/9040/1
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9040
to look at the new patch set (#3).
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
[catalog_manager] more info if unable to replace a replica
Output actionable warning message when the catalog manager is unable
to find a spot for a replacement replica. Since the 3-4-3 replication
scheme is now enabled by default, this might be useful in case if
running a cluster with just 3 tablet servers when tables have
replication factor of 3.
Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
3 files changed, 41 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/9040/3
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 3:
Shouldn't we also periodically print this warning even if the cluster is healthy and there are no replicas to replace?
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 02:47:41 +0000
Gerrit-HasComments: No
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9040
to look at the new patch set (#2).
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
[catalog_manager] more info if unable to replace a replica
Output actionable warning message when the catalog manager is unable
to find a place for a replacement replica. Since the 3-4-3 replication
scheme is now enabled by default, this might be useful in case if
running a cluster with just 3 tablet servers when tables have
replication factor of 3.
Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
3 files changed, 41 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/9040/2
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
[catalog_manager] more info if unable to replace a replica
Output actionable warning message when the catalog manager is unable
to find a spot for a replacement replica. Since the 3-4-3 replication
scheme is now enabled by default, this might be useful in case if
running a cluster with just 3 tablet servers when tables have
replication factor of 3.
Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Reviewed-on: http://gerrit.cloudera.org:8080/9040
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
3 files changed, 41 insertions(+), 9 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc@3164
PS2, Line 3164: should be present
how about: are required
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc@3172
PS2, Line 3172: KLOG_EVERY_N(WARNING, 100)
how about: KLOG_EVERY_N_SECS(WARNING, 60)
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 01:58:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 4:
> Shouldn't we also periodically print this warning even if the
> cluster is healthy and there are no replicas to replace?
One option I can see is to print this sort of warning every time a new table created with the replication factor greater than one and equal to the number of tablet servers in the cluster. Would it make sense?
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 04:10:19 +0000
Gerrit-HasComments: No
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 3:
> Shouldn't we also periodically print this warning even if the
> cluster is healthy and there are no replicas to replace?
I think that's a good idea. Where would it be the best place to add such a warning?
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 03:17:56 +0000
Gerrit-HasComments: No
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 02:45:59 +0000
Gerrit-HasComments: No
[kudu-CR] [catalog manager] more info if unable to replace a replica
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 )
Change subject: [catalog_manager] more info if unable to replace a replica
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc@3164
PS2, Line 3164: should be present
> how about: are required
Done
http://gerrit.cloudera.org:8080/#/c/9040/2/src/kudu/master/catalog_manager.cc@3172
PS2, Line 3172: KLOG_EVERY_N(WARNING, 100)
> how about: KLOG_EVERY_N_SECS(WARNING, 60)
Done
--
To view, visit http://gerrit.cloudera.org:8080/9040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f562c6d1ff526daa785ea535e440598c03cd37
Gerrit-Change-Number: 9040
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 17 Jan 2018 02:41:04 +0000
Gerrit-HasComments: Yes