You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Antonio Petrelli <ap...@apache.org> on 2006/10/18 13:28:27 UTC
[tiles2] Re: [jira] Updated: (SB-44) TilesContextFactory should be
a regular class
David H. DeWolf (JIRA) ha scritto:
> [ http://issues.apache.org/struts/browse/SB-44?page=all ]
>
> David H. DeWolf updated SB-44:
> ------------------------------
>
> Attachment: tiles-context-factory.465124.patch
>
> OK, try this one. . .it's against the head revision (as of right now).
>
> Since I got my karma today, I could also commit it to save you some time. Either way I'll give you a chance to review first since it's a good chunk of changes. Let me know. . .
>
There's something wrong with your patch, it does not apply correctly.
For instance I see the in some copyright notices:
<snip>
- * Copyright 1999-2006 The Apache Software Foundation.
- *
+ * Copyright 1999-2004 The Apache Software Foundation.
+ *
</snip>
And it seems there are too many differences for such a small change.
Please take a look before applying it!
Ciao
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [tiles2] Re: [jira] Updated: (SB-44) TilesContextFactory should
be a regular class
Posted by Antonio Petrelli <ap...@apache.org>.
David H. DeWolf ha scritto:
> hmmm. Not sure what that would be. Did you try the -l (ignore
> whitespace) option in patch?
Yes, it still does not apply...
I think that you have formatted your code, and then created the patch.
About the 1999-2004 well... I really don't understand it.
Please do not format the code, or the patch will become huge, and review
the changes before creating the patch.
Thank you
Ciao
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [tiles2] Re: [jira] Updated: (SB-44) TilesContextFactory should
be a regular class
Posted by "David H. DeWolf" <dd...@apache.org>.
hmmm. Not sure what that would be. Did you try the -l (ignore
whitespace) option in patch?
I'll start a new thread to discuss the specific items I'd like your
opinion on before committing.
David
Antonio Petrelli wrote:
> David H. DeWolf (JIRA) ha scritto:
>> [ http://issues.apache.org/struts/browse/SB-44?page=all ]
>>
>> David H. DeWolf updated SB-44:
>> ------------------------------
>>
>> Attachment: tiles-context-factory.465124.patch
>>
>> OK, try this one. . .it's against the head revision (as of right now).
>>
>> Since I got my karma today, I could also commit it to save you some
>> time. Either way I'll give you a chance to review first since it's a
>> good chunk of changes. Let me know. . .
>>
>
> There's something wrong with your patch, it does not apply correctly.
> For instance I see the in some copyright notices:
>
> <snip>
> - * Copyright 1999-2006 The Apache Software Foundation.
> - *
> + * Copyright 1999-2004 The Apache Software Foundation.
> + *
> </snip>
>
> And it seems there are too many differences for such a small change.
> Please take a look before applying it!
>
> Ciao
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org