You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/28 07:57:15 UTC
[GitHub] [hudi] swuferhong opened a new pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
swuferhong opened a new pull request #3361:
URL: https://github.com/apache/hudi/pull/3361
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Fix database alreadyExists exception while hive sync. Now, if the database exists, every hive sync process will throw database alreadyExists exception, this PR fix this problem and adding test case to cover different situation.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888099547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 648113e9ca1f1825a773c88ea0431ceba64e69ac UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888099547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"triggerType" : "PUSH"
}, {
"hash" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 648113e9ca1f1825a773c88ea0431ceba64e69ac UNKNOWN
* 7988786283d7d473f61c5ba0b573f4919f81210f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3361:
URL: https://github.com/apache/hudi/pull/3361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong commented on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
swuferhong commented on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888104415
hi @jsbali , when I tested the new hive sync code. I found if one database exists and hive sync mode setting as 'hms', every hive sync process wound throw database alreadyExists exception, so I tried to fix this problem and adding tests. And I also found a bug that $client.getDatabase(databaseName) throw noSuchObjectException instead of returning null while there is no database exists, which will influence the result when autoCreateDatabase setting false. Please have a look, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong edited a comment on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
swuferhong edited a comment on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888104415
hi @jsbali , when I tested the new hive sync code. I found if one database exists and hive sync mode setting as 'hms', every hive sync process wound throw database alreadyExists exception, so I tried to fix this problem and adding tests. And I also found a bug that $client.getDatabase(databaseName) throw noSuchObjectException instead of returning null while there is no database exists, which will influence the result when autoCreateDatabase setting false. PTAL, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong edited a comment on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
swuferhong edited a comment on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888104415
Hi @jsbali , when I tested the new hive sync code. I found if one database exists and hive sync mode setting as 'hms', every hive sync process wound throw database alreadyExists exception, so I tried to fix this problem and add tests. And I also found a bug that $client.getDatabase(databaseName) throw noSuchObjectException instead of returning null while there is no database exists, which will influence the result when autoCreateDatabase setting false. PTAL, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jsbali commented on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
jsbali commented on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888167710
Thanks @swuferhong for fixing it. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888099547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"triggerType" : "PUSH"
}, {
"hash" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1217",
"triggerID" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 648113e9ca1f1825a773c88ea0431ceba64e69ac UNKNOWN
* 7988786283d7d473f61c5ba0b573f4919f81210f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1217)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong closed pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
swuferhong closed pull request #3361:
URL: https://github.com/apache/hudi/pull/3361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3361: [HUDI-2244] Fix database alreadyExists exception while hive sync
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3361:
URL: https://github.com/apache/hudi/pull/3361#issuecomment-888099547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "648113e9ca1f1825a773c88ea0431ceba64e69ac",
"triggerType" : "PUSH"
}, {
"hash" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1217",
"triggerID" : "7988786283d7d473f61c5ba0b573f4919f81210f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 648113e9ca1f1825a773c88ea0431ceba64e69ac UNKNOWN
* 7988786283d7d473f61c5ba0b573f4919f81210f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1217)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org