You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2026/10/16 07:48:46 UTC
[PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
kou opened a new pull request, #53952:
URL: https://github.com/apache/arrow/pull/53952
### Rationale for this change
`simdjson >= 5` uses GCC builtins such as `__builtin_ctz` when `__SSE2__` is defined. So we can't build Apache Arrow C++ with `simdjson >= 5` and MSVC because we define `__SSE2__` globally.
### What changes are included in this PR?
We don't need to define `__SSE2__` because xsimd detects SSE2 by `_M_X64` with MSVC.
We still need to define `__SSE4_1__`/`__SSE4_2__` for xsimd because MSVC doesn't define them even with `/arch:SSE4.2`. But we define them only where SSE4.2 is enabled. So they are no longer defined with `ARROW_SIMD_LEVEL=NONE`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
### Was AI used for this PR?
In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR.
**PR code and description written by:**
- [x] Human
- [x] AI
**Reviewed before submission by:**
- [x] Human
- [ ] AI
- [ ] Not reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6210908471
Revision: 342b329fdbdd7209ebe6d7bc4b3b557568897a76
Submitted crossbow builds: [ursacomputing/crossbow @ actions-574d24d44c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-574d24d44c)
|Task|Status|
|----|------|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/38870721496/job/116873912336)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6210778228
:warning: GitHub issue #51690 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #53952:
URL: https://github.com/apache/arrow/pull/53952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6356365579
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6363173250
Thanks for working on this @kou! Sorry I missed this was ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6367363745
No problem! I had forgotten about this too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51690: [C++] Don't define __SSE2__ globally with MSVC [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #53952:
URL: https://github.com/apache/arrow/pull/53952#issuecomment-6210723092
@github-actions crossbow submit verify-rc-source-windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org