[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #231: RATIS-1105. Refactor Netty streaming encoder and decoder.

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #231:
URL: https://github.com/apache/incubator-ratis/pull/231#discussion_r511237331



##########
File path: ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyServerStreamRpc.java
##########
@@ -234,7 +236,8 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws IOExceptio
           }
         }
 
-        JavaUtils.allOf(remoteWrites).thenCombine(localWrite, (v, bytesWritten) -> {
+        previous = previous.thenCombine(JavaUtils.allOf(remoteWrites), (u, v) -> null)
+            .thenCombine(localWrite, (v, bytesWritten) -> {

Review comment:
       > ... slow previous will slow down the following request.  ...
   
   It is a correct behaviour for Streaming.  Streaming is FIFO like a queue.  We should guarantee the replies are in-ordered.
   
   It is not an unordered RPC which allows later requests replied before the earlier requests.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org