[GitHub] [jackrabbit-oak] anchela commented on a diff in pull request #594: OAK-9801 improve error messages

[GitBox <gi...@apache.org>]

anchela commented on code in PR #594:
URL: https://github.com/apache/jackrabbit-oak/pull/594#discussion_r896498694


##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java:
##########
@@ -223,7 +220,7 @@ public Property performNullable() {
     @Override
     @Nullable
     public Item getItemOrNull(final String absPath) throws RepositoryException {

Review Comment:
   could we also mark the param as @NotNull in the jackrabbit API and here?



##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java:
##########
@@ -197,7 +194,7 @@ public Node performNullable() throws RepositoryException {
     @Nullable
     public Property getPropertyOrNull(final String absPath) throws RepositoryException {

Review Comment:
   could we mark the param as NotNull in the jackrabbit-api and here? that might actually spare us the null check altogether..... couldn't it?



##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java:
##########
@@ -179,7 +176,7 @@ private ItemImpl<?> getItemInternal(@NotNull String oakPath)
     @Override
     @Nullable
     public Node getNodeOrNull(final String absPath) throws RepositoryException {

Review Comment:
   could we also mark the param as NotNull in the jackrabbit-api and here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org