You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/29 17:47:53 UTC
[kudu-CR] [python] - Add BlockSize method to ColumnSpec
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4884
Change subject: [python] - Add BlockSize method to ColumnSpec
......................................................................
[python] - Add BlockSize method to ColumnSpec
The ColumnSpec class currently doesn't expose the BlockSize method.
This patch adds that and includes a test.
Change-Id: I29c272efe1745c830054f081b311c34488f0d5c7
---
M python/kudu/schema.pyx
M python/kudu/tests/test_schema.py
2 files changed, 30 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4884/1
--
To view, visit http://gerrit.cloudera.org:8080/4884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29c272efe1745c830054f081b311c34488f0d5c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] [python] - Add BlockSize method to ColumnSpec
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [python] - Add BlockSize method to ColumnSpec
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29c272efe1745c830054f081b311c34488f0d5c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [python] - Add BlockSize method to ColumnSpec
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [python] - Add BlockSize method to ColumnSpec
......................................................................
[python] - Add BlockSize method to ColumnSpec
The ColumnSpec class currently doesn't expose the BlockSize method.
This patch adds that and includes a test.
Change-Id: I29c272efe1745c830054f081b311c34488f0d5c7
Reviewed-on: http://gerrit.cloudera.org:8080/4884
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M python/kudu/schema.pyx
M python/kudu/tests/test_schema.py
2 files changed, 30 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29c272efe1745c830054f081b311c34488f0d5c7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>