[GitHub] [datasketches-cpp] AlexanderSaydakov commented on pull request #357: theta union get_result() fix

["AlexanderSaydakov (via GitHub)" <gi...@apache.org>]

AlexanderSaydakov commented on PR #357:
URL: https://github.com/apache/datasketches-cpp/pull/357#issuecomment-1506039505

   The essence of the fix is line 68: if(union_theta_ >= table_.theta_) as opposed to if(union_theta_ >= theta).
   The rest is for clarity (slightly rearranged flow in get_result) and efficiency (std::min instead of conditions).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org