You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2023/06/19 13:07:33 UTC
[GitHub] [doris] kaka11chen opened a new pull request, #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
kaka11chen opened a new pull request, #20998:
URL: https://github.com/apache/doris/pull/20998
## Proposed changes
Fix filter size mismatch in orc reader.
error msg:
```
F0618 05:21:17.627173 949027 column_string.cpp:160] Check failed: filter.s ize() == offsets.size() (3744 vs. 236)
Query id: aa156820f6654597-b2ed83af6671e181 ***
40050 *** Aborted at 1687036877 (unix time) try "date -d @1687036877" if you are using GNU date ***
40051 *** Current BE git commitID: 0585a1f004 ***
40052 *** SIGABRT unknown detail explain (@0xbb704) received by PID 767748 (TID 949027 OR 0x7fa760fe6640) from PID 767748; stack trace: ***
40053 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginf o_t*, void*) at /mnt/hdd01/repo_center/doris_branch-2.0/doris/be/src/commo n/signal_handler.h:413
40054 1# 0x00007FCA6EC8C040 in /lib/x86_64-linux-gnu/libc.so.6
40055 2# raise in /lib/x86_64-linux-gnu/libc.so.6
40056 3# abort in /lib/x86_64-linux-gnu/libc.so.6
40057 4# 0x000056263ADD9A19 in /mnt/hdd01/dorisTestEnv/VEC_ASAN/be/lib/doris_be
40058 5# google::LogMessage::SendToLog() in /mnt/hdd01/dorisTestEnv/VEC_ASAN/be /lib/doris_be
40059 6# google::LogMessage::Flush() in /mnt/hdd01/dorisTestEnv/VEC_ASAN/be/lib /doris_be
40060 7# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/dorisTestEnv /VEC_ASAN/be/lib/doris_be
8# doris::vectorized::ColumnString::filter(doris::vectorized::PODArray<un signed char, 4096ul, Allocator<false, false, true>, 15ul, 16ul> const&) in /mnt/hdd01/dorisTestEnv/VEC_ASAN/be/lib/doris_be
40062 9# doris::vectorized::ColumnNullable::filter(doris::vectorized::PODArray< unsigned char, 4096ul, Allocator<false, false, true>, 15ul, 16ul> const&) at /mnt/hdd01/repo_center/doris_branch-2.0/doris/be/src/vec/columns/column _nullable.cpp:321
40063 10# doris::vectorized::Block::filter_block_internal(doris::vectorized::Blo ck*, std::vector<unsigned int, std::allocator<unsigned int> > const&, dori s::vectorized::PODArray<unsigned char, 4096ul, Allocator<false, false, tru e>, 15ul, 16ul> const&) at /mnt/hdd01/repo_center/doris_branch-2.0/doris/b e/src/vec/core/block.cpp:703
40064 11# doris::vectorized::OrcReader::get_next_block(doris::vectorized::Block* , unsigned long*, bool*) at /mnt/hdd01/repo_center/doris_branch-2.0/doris/ be/src/vec/exec/format/orc/vorc_reader.cpp:1387
40065 12# doris::vectorized::VFileScanner::_get_block_impl(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /mnt/hdd01/repo_center/doris_branch- 2.0/doris/be/src/vec/exec/scan/vfile_scanner.cpp:259
40066 13# doris::vectorized::VScanner::get_block(doris::RuntimeState*, doris::ve ctorized::Block*, bool*) in /mnt/hdd01/dorisTestEnv/VEC_ASAN/be/lib/doris_be
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20998:
URL: https://github.com/apache/doris/pull/20998#issuecomment-1598053458
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #20998:
URL: https://github.com/apache/doris/pull/20998#issuecomment-1597178467
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on a diff in pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on code in PR #20998:
URL: https://github.com/apache/doris/pull/20998#discussion_r1234690651
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1123,8 +1127,7 @@ Status OrcReader::_decode_string_dict_encoded_column(const std::string& col_name
}
}
}
- data_column->insert_many_strings_overflow(&string_values[0], string_values.size(),
Review Comment:
Why change `insert_many_strings_overflow` as `insert_many_strings`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kaka11chen commented on a diff in pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on code in PR #20998:
URL: https://github.com/apache/doris/pull/20998#discussion_r1234691112
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -1123,8 +1127,7 @@ Status OrcReader::_decode_string_dict_encoded_column(const std::string& col_name
}
}
}
- data_column->insert_many_strings_overflow(&string_values[0], string_values.size(),
Review Comment:
`insert_many_strings_overflow` need memory continuously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #20998:
URL: https://github.com/apache/doris/pull/20998#issuecomment-1598056901
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20998:
URL: https://github.com/apache/doris/pull/20998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20998:
URL: https://github.com/apache/doris/pull/20998#issuecomment-1598053493
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20998: [Fix](orc-reader) Fix filter size mismatch in orc reader.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20998:
URL: https://github.com/apache/doris/pull/20998#issuecomment-1597172915
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org