You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Geoff Callender (JIRA)" <ji...@apache.org> on 2009/08/12 01:20:14 UTC

[jira] Created: (TAP5-812) The documentation shows doing validation in onSuccess()

The documentation shows doing validation in onSuccess()
-------------------------------------------------------

                 Key: TAP5-812
                 URL: https://issues.apache.org/jira/browse/TAP5-812
             Project: Tapestry 5
          Issue Type: Bug
          Components: documentation
    Affects Versions: 5.1.0.5
            Reporter: Geoff Callender


The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed inline with TAPESTRY-1972 .

Instead of this...

    String onSuccess()
    {
        if (!authenticator.isValid(userName, password))
        {
            form.recordError(passwordField, "Invalid user name or password.");
            return null;
        }

        return "PostLogin";
    }

...it should be...

   String onValidateForm()
   {
       if (!authenticator.isValid(userName, password))
       {
           form.recordError(passwordField, "Invalid user name or password.");
       }
   }

   String onSuccess()
   {
       return "PostLogin";
   }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-812:
--------------------------------------

    Summary: The input validation documentation incorrectly shows validation occuring in the success event handler method  (was: The documentation shows doing validation in onSuccess())

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-812:
-----------------------------------------

    Assignee: Howard M. Lewis Ship

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-812:
-----------------------------------------

    Assignee: Howard M. Lewis Ship

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TAP5-812) The documentation shows doing validation in onSuccess()

Posted by "Geoff Callender (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Callender updated TAP5-812:
---------------------------------

    Description: 
The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .

Instead of this...

    String onSuccess()
    {
        if (!authenticator.isValid(userName, password))
        {
            form.recordError(passwordField, "Invalid user name or password.");
            return null;
        }

        return "PostLogin";
    }

...it should be...

   String onValidateForm()
   {
       if (!authenticator.isValid(userName, password))
       {
           form.recordError(passwordField, "Invalid user name or password.");
       }
   }

   String onSuccess()
   {
       return "PostLogin";
   }


  was:
The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed inline with TAPESTRY-1972 .

Instead of this...

    String onSuccess()
    {
        if (!authenticator.isValid(userName, password))
        {
            form.recordError(passwordField, "Invalid user name or password.");
            return null;
        }

        return "PostLogin";
    }

...it should be...

   String onValidateForm()
   {
       if (!authenticator.isValid(userName, password))
       {
           form.recordError(passwordField, "Invalid user name or password.");
       }
   }

   String onSuccess()
   {
       return "PostLogin";
   }



> The documentation shows doing validation in onSuccess()
> -------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TAP5-812) The documentation shows doing validation in onSuccess()

Posted by "Geoff Callender (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Callender updated TAP5-812:
---------------------------------

    Description: 
The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .

Instead of this...

    String onSuccess()
    {
        if (!authenticator.isValid(userName, password))
        {
            form.recordError(passwordField, "Invalid user name or password.");
            return null;
        }

        return "PostLogin";
    }

...it should be...

   String onValidateForm()
   {
       if (!authenticator.isValid(userName, password))
       {
           form.recordError(passwordField, "Invalid user name or password.");
       }
   }

   String onSuccess()
   {
       return "PostLogin";
   }


  was:
The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed inline with TAPESTRY-1972 .

Instead of this...

    String onSuccess()
    {
        if (!authenticator.isValid(userName, password))
        {
            form.recordError(passwordField, "Invalid user name or password.");
            return null;
        }

        return "PostLogin";
    }

...it should be...

   String onValidateForm()
   {
       if (!authenticator.isValid(userName, password))
       {
           form.recordError(passwordField, "Invalid user name or password.");
       }
   }

   String onSuccess()
   {
       return "PostLogin";
   }



> The documentation shows doing validation in onSuccess()
> -------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-812.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.2.0

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-812.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.2.0

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-812:
--------------------------------------

    Summary: The input validation documentation incorrectly shows validation occuring in the success event handler method  (was: The documentation shows doing validation in onSuccess())

> The input validation documentation incorrectly shows validation occuring in the success event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.1.0.5
>            Reporter: Geoff Callender
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.