You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/08/24 05:39:50 UTC
[GitHub] [myfaces] pnicolucci opened a new pull request, #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
pnicolucci opened a new pull request, #288:
URL: https://github.com/apache/myfaces/pull/288
This fixes MYFACES-4442: https://issues.apache.org/jira/browse/MYFACES-4442
I have to rummage around in the commit history of the current branches and find where these classes used to reside:
1. [ServletMapping](https://github.com/apache/myfaces/commit/ae3da459a80115650e81ca89d870183f0c9c434b#diff-38135243715d25b010f65297f26b41e66cc7205a2d6b9672407fc5d52c301bbb)
2. [WebXml](https://github.com/apache/myfaces/commit/115e2e3a3817e9fdf091a8672dc3bfd58a02ecdb#diff-65b3eb07dd1234eefee5b611904e4af48a2d4a53043ca72c7377e00c37d774ae) I updated this class to correct javax->jakarta, ClassUtils current package, updated import for DelegatedFacesServlet, and updated package for WebXmlParser.
3. [WebXmlParser](https://github.com/apache/myfaces/blob/3.0.x/impl/src/main/java/org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java) Already existed. [History of WebXmlParser](https://github.com/apache/myfaces/commits/main/impl/src/main/java/org/apache/myfaces/util/WebXmlParser.java) I added the following back to it and modified it as necessary to fit into the latest code base: [This is what it looked like before it was moved in the same commit](https://github.com/apache/myfaces/commit/ca63ed50afd5caec20f816864cbce196013e1cbd)
4. [WebXmlParserErrorHandler](https://github.com/apache/myfaces/commit/ca63ed50afd5caec20f816864cbce196013e1cbd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci closed pull request #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
Posted by GitBox <gi...@apache.org>.
pnicolucci closed pull request #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
URL: https://github.com/apache/myfaces/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #288:
URL: https://github.com/apache/myfaces/pull/288#issuecomment-1226881756
I think the fallback should be directly in FacesServletMappingUtils.getFacesServletRegistration
AFAICS we dont scan web-fragments? Thats a must have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #288:
URL: https://github.com/apache/myfaces/pull/288#issuecomment-1229613537
@tandraschko I have another idea and I think we can avoid this web.xml parsing altogether. I'll work to get a new PR to share my findings and we can discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #288: MYFACES-4442: Fix UnsupportedOperationException during Faces init
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #288:
URL: https://github.com/apache/myfaces/pull/288#issuecomment-1229613537
@tandraschko I have another idea and I think we can avoid this web.xml parsing altogether. I'll work to get a new PR to share my findings and we can discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org