You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/28 20:54:45 UTC
Review Request 67773: Removed redundant 'toUnreserved()' call in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67773/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Greg Mann.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp cbdfb2ba9c25755ac631557e0e7dbd721f861a4d
Diff: https://reviews.apache.org/r/67773/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 67773: Removed redundant 'toUnreserved()' call in
the allocator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67773/#review205536
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On June 28, 2018, 8:54 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67773/
> -----------------------------------------------------------
>
> (Updated June 28, 2018, 8:54 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp cbdfb2ba9c25755ac631557e0e7dbd721f861a4d
>
>
> Diff: https://reviews.apache.org/r/67773/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67773: Removed redundant 'toUnreserved()' call in
the allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67773/#review205648
-----------------------------------------------------------
Ship it!
Will add the following to the description:
```
This call is no longer necessary as the reservation metadata is now
stripped by `createStrippedScalarQuantity`.
```
- Benjamin Mahler
On June 28, 2018, 8:54 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67773/
> -----------------------------------------------------------
>
> (Updated June 28, 2018, 8:54 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp cbdfb2ba9c25755ac631557e0e7dbd721f861a4d
>
>
> Diff: https://reviews.apache.org/r/67773/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>