[GitHub] rabbah commented on a change in pull request #2517: Support client certificate verify on server side

[gi...@git.apache.org]

rabbah commented on a change in pull request #2517: Support client certificate verify on server side
URL: https://github.com/apache/incubator-openwhisk/pull/2517#discussion_r131046543
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala
 ##########
 @@ -74,6 +74,53 @@ object Identity extends MultipleReadersSingleWriterCache[Identity, DocInfo] with
         })
     }
 
+    /**
+      * Many subjects can be belonged to only one namespace
+      * Retrieves a key for namespace + subject.
+      *
+      */
+    def get(datastore: AuthStore, namespace: EntityName, subject: Subject)(
 
 Review comment:
   we don't need a view to look up by subject - it is a primary index.
   
   i suspect though i did not try, that you can do get on AuthStore to fetch the subject, and parameterize that on the type of a subject record. i'll create a gist for you.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services