[GitHub] [druid] zachjsh commented on a change in pull request #9459: Ability to Delete task logs and segments from S3

[GitBox <gi...@apache.org>]

zachjsh commented on a change in pull request #9459: Ability to Delete task logs and segments from S3
URL: https://github.com/apache/druid/pull/9459#discussion_r388805581
 
 

 ##########
 File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentKiller.java
 ##########
 @@ -69,8 +85,48 @@ public void kill(DataSegment segment) throws SegmentLoadingException
   }
 
   @Override
-  public void killAll()
+  public void killAll() throws IOException
   {
-    throw new UnsupportedOperationException("not implemented");
+    try {
+      S3Utils.retryS3Operation(
+          () -> {
+            String bucketName = segmentPusherConfig.getBucket();
 
 Review comment:
   Good point about reusing the object iterator, I actually thought about that before, not sure why I decided against. As you said its good that all the listing code is shared in this case. I believe that I would want to skip directories in this case too, so that should be good here as well. Thanks for the suggestion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org