You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nathan Hartman <ha...@gmail.com> on 2021/01/22 21:52:27 UTC

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

On Fri, Oct 16, 2020 at 1:58 PM Alexandr Miloslavskiy
<al...@syntevo.com> wrote:
>
> I have committed a series of patches for JavaHL on 'javahl-1.14-fixes'
> branch. They mostly address crashes when using TunnelAgent, but also fix
> some JNI warnings.
>
> The branch also includes automatic tests for problems I fixed. If you
> only checkout the first commit of the branch, there will be tests
> without any fixes. Adding more commits will gradually fix problems
> demonstrated by the new tests.
>
> Now I hope for some attention and reviews :)
>
> Here's how to run JavaHL tests on macOS/Linux:
> ----------------------------------------------
> 1) Download [1] JDK and extract it to some folder, for example
> /home/user/Downloads/jdk. I have tested with versions 8 and 14, haven't
> yet tried the newest version 15.
> 2) Download [2] JUnit and put .jar to some folder, for example
> /home/user/Downloads/junit.
> 3) During 'configure' SVN build step, pass additional arguments:
>      --with-jdk=/home/user/Downloads/jdk
>      --with-junit=/home/user/Downloads/junit/junit-4.12.jar
>      --enable-javahl
> 4) Compile with:
>      make javahl
> 5) Run tests with:
>      make check-apache-javahl
>
> [1] https://www.oracle.com/java/technologies/javase-jdk14-downloads.html
> [2] https://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.jar

Just resurrecting the above from the mists of the mailing list...

Would anyone who feels at home with Java be inclined to review the
javahl-1.14-fixes branch in time to merge/nominate it for 1.14.1? It's
supposed to fix a few crashes (see quoted message above). (What
stopped me from doing it already is that I need to diagnose why my
system wouldn't run the JavaHL tests.)

My intention for this weekend is to:

(1) write a regression test for the 'svn info --xml' bug and then
    commit the fix from a few days ago in [1]

(2) review/test/vote on STATUS for 1.10.x and 1.14.x

(3) if time remains, fix whatever is broken on my system and review
    that branch

If someone could beat me to #3, I'll be very grateful.

Cheers,
Nathan

[1] https://mail-archives.apache.org/mod_mbox/subversion-dev/202101.mbox/%3cCAJT2EHpwnG8jcZ_mzR3zHqwXZxPdBoi27ggaXiDGhm3Mg12wBQ@mail.gmail.com%3e

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Jan 27, 2021 at 2:40 AM Johan Corveleyn <jc...@gmail.com> wrote:
>
> On Tue, Jan 26, 2021 at 9:56 PM Johan Corveleyn <jc...@gmail.com> wrote:
> >
> > On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
> > <al...@syntevo.com> wrote:
> > >
> > > On 25.01.2021 1:55, Johan Corveleyn wrote:
> > >
> > > > As an update: I've started looking into this, but it's a bit more work
> > > > than I anticipated. I want to understand and properly review the
> > > > changes.
> > >
> > > Thanks! I already started thinking that all hope is lost :)
> > >
> > > The branch contains additional tests (added over a few commits). If you
> > > keep the tests but discard my patches to JavaHL, you'll see the crashes.
> > > With patches, crashes are no more.
> > >
> > > I tried to properly explain everything in code comments and commit
> > > messages. However, if you have any questions, please ask, and I'll do my
> > > best to explain.
> >
> > Great! Thanks for sticking around. I'll try to get through it all :-).
>
> Okay, I went through it all, and it looks good to me. Those are some
> pretty delicate bugs / fixes, so thanks for explaining everything so
> well in the comments and commit messages. Great work!
>
> Apart from reading the code, I've applied the tests and their fixes
> individually to better understand them, and to make sure they first
> failed on my system and were subsequently fixed by the corresponding
> fix. After that, I'm satisfied that they are a good step forward.
>
> I did have a couple of tiny questions / remarks, but I'm going to get
> back to them tomorrow, after another fresh look.

Done.

@Alexandr: if you could please take a look at the small remarks /
questions I raised on r1882520, r1882522 and r1882523, that would be
great.

Thanks,
-- 
Johan

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Johan Corveleyn <jc...@gmail.com>.
On Tue, Jan 26, 2021 at 9:56 PM Johan Corveleyn <jc...@gmail.com> wrote:
>
> On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
> <al...@syntevo.com> wrote:
> >
> > On 25.01.2021 1:55, Johan Corveleyn wrote:
> >
> > > As an update: I've started looking into this, but it's a bit more work
> > > than I anticipated. I want to understand and properly review the
> > > changes.
> >
> > Thanks! I already started thinking that all hope is lost :)
> >
> > The branch contains additional tests (added over a few commits). If you
> > keep the tests but discard my patches to JavaHL, you'll see the crashes.
> > With patches, crashes are no more.
> >
> > I tried to properly explain everything in code comments and commit
> > messages. However, if you have any questions, please ask, and I'll do my
> > best to explain.
>
> Great! Thanks for sticking around. I'll try to get through it all :-).

Okay, I went through it all, and it looks good to me. Those are some
pretty delicate bugs / fixes, so thanks for explaining everything so
well in the comments and commit messages. Great work!

Apart from reading the code, I've applied the tests and their fixes
individually to better understand them, and to make sure they first
failed on my system and were subsequently fixed by the corresponding
fix. After that, I'm satisfied that they are a good step forward.

I did have a couple of tiny questions / remarks, but I'm going to get
back to them tomorrow, after another fresh look.

-- 
Johan

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Johan Corveleyn <jc...@gmail.com>.
On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
<al...@syntevo.com> wrote:
>
> On 25.01.2021 1:55, Johan Corveleyn wrote:
>
> > As an update: I've started looking into this, but it's a bit more work
> > than I anticipated. I want to understand and properly review the
> > changes.
>
> Thanks! I already started thinking that all hope is lost :)
>
> The branch contains additional tests (added over a few commits). If you
> keep the tests but discard my patches to JavaHL, you'll see the crashes.
> With patches, crashes are no more.
>
> I tried to properly explain everything in code comments and commit
> messages. However, if you have any questions, please ask, and I'll do my
> best to explain.

Great! Thanks for sticking around. I'll try to get through it all :-).

-- 
Johan

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Alexandr Miloslavskiy <al...@syntevo.com>.
On 25.01.2021 1:55, Johan Corveleyn wrote:

> As an update: I've started looking into this, but it's a bit more work
> than I anticipated. I want to understand and properly review the
> changes.

Thanks! I already started thinking that all hope is lost :)

The branch contains additional tests (added over a few commits). If you 
keep the tests but discard my patches to JavaHL, you'll see the crashes. 
With patches, crashes are no more.

I tried to properly explain everything in code comments and commit 
messages. However, if you have any questions, please ask, and I'll do my 
best to explain.

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Johan Corveleyn <jc...@gmail.com>.
On Sat, Jan 23, 2021 at 11:10 AM Johan Corveleyn <jc...@gmail.com> wrote:
>
> On Fri, Jan 22, 2021 at 10:52 PM Nathan Hartman
> <ha...@gmail.com> wrote:
> >
> > On Fri, Oct 16, 2020 at 1:58 PM Alexandr Miloslavskiy
> > <al...@syntevo.com> wrote:
> > >
> > > I have committed a series of patches for JavaHL on 'javahl-1.14-fixes'
> > > branch. They mostly address crashes when using TunnelAgent, but also fix
> > > some JNI warnings.
> > >
> > > The branch also includes automatic tests for problems I fixed. If you
> > > only checkout the first commit of the branch, there will be tests
> > > without any fixes. Adding more commits will gradually fix problems
> > > demonstrated by the new tests.
> > >
> > > Now I hope for some attention and reviews :)
> > >
> > > Here's how to run JavaHL tests on macOS/Linux:
> > > ----------------------------------------------
> > > 1) Download [1] JDK and extract it to some folder, for example
> > > /home/user/Downloads/jdk. I have tested with versions 8 and 14, haven't
> > > yet tried the newest version 15.
> > > 2) Download [2] JUnit and put .jar to some folder, for example
> > > /home/user/Downloads/junit.
> > > 3) During 'configure' SVN build step, pass additional arguments:
> > >      --with-jdk=/home/user/Downloads/jdk
> > >      --with-junit=/home/user/Downloads/junit/junit-4.12.jar
> > >      --enable-javahl
> > > 4) Compile with:
> > >      make javahl
> > > 5) Run tests with:
> > >      make check-apache-javahl
> > >
> > > [1] https://www.oracle.com/java/technologies/javase-jdk14-downloads.html
> > > [2] https://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.jar
> >
> > Just resurrecting the above from the mists of the mailing list...
> >
> > Would anyone who feels at home with Java be inclined to review the
> > javahl-1.14-fixes branch in time to merge/nominate it for 1.14.1? It's
> > supposed to fix a few crashes (see quoted message above). (What
> > stopped me from doing it already is that I need to diagnose why my
> > system wouldn't run the JavaHL tests.)
> >
> > My intention for this weekend is to:
> >
> > (1) write a regression test for the 'svn info --xml' bug and then
> >     commit the fix from a few days ago in [1]
> >
> > (2) review/test/vote on STATUS for 1.10.x and 1.14.x
> >
> > (3) if time remains, fix whatever is broken on my system and review
> >     that branch
> >
> > If someone could beat me to #3, I'll be very grateful.
> >
> > Cheers,
> > Nathan
> >
> > [1] https://mail-archives.apache.org/mod_mbox/subversion-dev/202101.mbox/%3cCAJT2EHpwnG8jcZ_mzR3zHqwXZxPdBoi27ggaXiDGhm3Mg12wBQ@mail.gmail.com%3e
>
> Ah, thanks for bringing this back up, and sorry to Alexandr for
> letting this linger for so long.
>
> I'll try to take a closer look this weekend. I am a Java developer in
> my $dayjob, but I don't know much about JNI nor about JavaHL. Anyway,
> I should be able to dig into it, and at least I already have the
> JavaHL testsuite running successfully here :-).
>
> Of course if someone else, who knows a bit about JavaHL perhaps, can
> beat me / us to it, I wouldn't object ;-).

As an update: I've started looking into this, but it's a bit more work
than I anticipated. I want to understand and properly review the
changes. I'll do my best to do this the coming days, but I can't make
any guarantees. So far, I've checked out the javahl-1.14-fixes branch
(which is a branch from trunk, BTW -- after review we should first
merge this to trunk, and then nominate for backport to 1.14.x), built
it and I ran the javahl testsuite successfully (on Windows).

Alexandr, sorry for the long delay. I hope we can make some progress
to review your fixes in time and get them in.

-- 
Johan

Re: A series of JavaHL fixes on branch 'javahl-1.14-fixes'

Posted by Johan Corveleyn <jc...@gmail.com>.
On Fri, Jan 22, 2021 at 10:52 PM Nathan Hartman
<ha...@gmail.com> wrote:
>
> On Fri, Oct 16, 2020 at 1:58 PM Alexandr Miloslavskiy
> <al...@syntevo.com> wrote:
> >
> > I have committed a series of patches for JavaHL on 'javahl-1.14-fixes'
> > branch. They mostly address crashes when using TunnelAgent, but also fix
> > some JNI warnings.
> >
> > The branch also includes automatic tests for problems I fixed. If you
> > only checkout the first commit of the branch, there will be tests
> > without any fixes. Adding more commits will gradually fix problems
> > demonstrated by the new tests.
> >
> > Now I hope for some attention and reviews :)
> >
> > Here's how to run JavaHL tests on macOS/Linux:
> > ----------------------------------------------
> > 1) Download [1] JDK and extract it to some folder, for example
> > /home/user/Downloads/jdk. I have tested with versions 8 and 14, haven't
> > yet tried the newest version 15.
> > 2) Download [2] JUnit and put .jar to some folder, for example
> > /home/user/Downloads/junit.
> > 3) During 'configure' SVN build step, pass additional arguments:
> >      --with-jdk=/home/user/Downloads/jdk
> >      --with-junit=/home/user/Downloads/junit/junit-4.12.jar
> >      --enable-javahl
> > 4) Compile with:
> >      make javahl
> > 5) Run tests with:
> >      make check-apache-javahl
> >
> > [1] https://www.oracle.com/java/technologies/javase-jdk14-downloads.html
> > [2] https://repo1.maven.org/maven2/junit/junit/4.12/junit-4.12.jar
>
> Just resurrecting the above from the mists of the mailing list...
>
> Would anyone who feels at home with Java be inclined to review the
> javahl-1.14-fixes branch in time to merge/nominate it for 1.14.1? It's
> supposed to fix a few crashes (see quoted message above). (What
> stopped me from doing it already is that I need to diagnose why my
> system wouldn't run the JavaHL tests.)
>
> My intention for this weekend is to:
>
> (1) write a regression test for the 'svn info --xml' bug and then
>     commit the fix from a few days ago in [1]
>
> (2) review/test/vote on STATUS for 1.10.x and 1.14.x
>
> (3) if time remains, fix whatever is broken on my system and review
>     that branch
>
> If someone could beat me to #3, I'll be very grateful.
>
> Cheers,
> Nathan
>
> [1] https://mail-archives.apache.org/mod_mbox/subversion-dev/202101.mbox/%3cCAJT2EHpwnG8jcZ_mzR3zHqwXZxPdBoi27ggaXiDGhm3Mg12wBQ@mail.gmail.com%3e

Ah, thanks for bringing this back up, and sorry to Alexandr for
letting this linger for so long.

I'll try to take a closer look this weekend. I am a Java developer in
my $dayjob, but I don't know much about JNI nor about JavaHL. Anyway,
I should be able to dig into it, and at least I already have the
JavaHL testsuite running successfully here :-).

Of course if someone else, who knows a bit about JavaHL perhaps, can
beat me / us to it, I wouldn't object ;-).

-- 
Johan