You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2020/01/17 12:30:49 UTC

[plc4x] branch develop updated: - Made the ProtocolTestsuiteRunner ignore differences in comments

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new b208334  - Made the ProtocolTestsuiteRunner ignore differences in comments
b208334 is described below

commit b2083346db26315ebc958dc2294924822f8843e3
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Fri Jan 17 13:30:42 2020 +0100

    - Made the ProtocolTestsuiteRunner ignore differences in comments
---
 .../java/org/apache/plc4x/test/protocol/ProtocolTestsuiteRunner.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plc4j/utils/test-utils/src/main/java/org/apache/plc4x/test/protocol/ProtocolTestsuiteRunner.java b/plc4j/utils/test-utils/src/main/java/org/apache/plc4x/test/protocol/ProtocolTestsuiteRunner.java
index 6bceb0f..dfd4c91 100644
--- a/plc4j/utils/test-utils/src/main/java/org/apache/plc4x/test/protocol/ProtocolTestsuiteRunner.java
+++ b/plc4j/utils/test-utils/src/main/java/org/apache/plc4x/test/protocol/ProtocolTestsuiteRunner.java
@@ -112,7 +112,7 @@ public class ProtocolTestsuiteRunner {
         try {
             Object msg = messageIO.parse(readBuffer);
             String xmlString = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(msg);
-            Diff diff = DiffBuilder.compare(referenceXml).withTest(xmlString).ignoreWhitespace().build();
+            Diff diff = DiffBuilder.compare(referenceXml).withTest(xmlString).ignoreComments().ignoreWhitespace().build();
             if(diff.hasDifferences()) {
                 System.out.println(xmlString);
                 throw new ProtocolTestsuiteException("Differences were found after parsing.\n" + diff.toString());