You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/08 08:30:09 UTC
[GitHub] [skywalking] czeeland opened a new issue #4759: not support springmvc [server.servlet.context-path]
czeeland opened a new issue #4759:
URL: https://github.com/apache/skywalking/issues/4759
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Bug
___
### Bug
- Which version of SkyWalking, OS and JRE?
7.0.x
- What happen?
Because skywalking override getRequestURL method recursive annotaion, not support springmvc configration param [server.servlet.context-path], cause skywalking-oap search endpoint question。
if request failure before controller method, like springboot interceptor，it will has the not same endpoint。
`java
public class RequestMappingMethodInterceptor extends AbstractMethodInterceptor {
@Override
public String getRequestURL(Method method) {
return ParsePathUtil.recursiveParseMethodAnnotaion(method, m -> {
String requestURL = null;
RequestMapping methodRequestMapping = AnnotationUtils.getAnnotation(m, RequestMapping.class);
if (methodRequestMapping != null) {
if (methodRequestMapping.value().length > 0) {
requestURL = methodRequestMapping.value()[0];
} else if (methodRequestMapping.path().length > 0) {
requestURL = methodRequestMapping.path()[0];
}
}
return requestURL;
});
}
}
`
`java
if (Config.Plugin.SpringMVC.USE_QUALIFIED_NAME_AS_ENDPOINT_NAME) {
operationName = MethodUtil.generateOperationName(method);
} else {
EnhanceRequireObjectCache pathMappingCache = (EnhanceRequireObjectCache) objInst.getSkyWalkingDynamicField();
String requestURL = pathMappingCache.findPathMapping(method);
if (requestURL == null) {
requestURL = getRequestURL(method);
pathMappingCache.addPathMapping(method, requestURL);
requestURL = getAcceptedMethodTypes(method) + pathMappingCache.findPathMapping(method);
}
operationName = requestURL;
}
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626116124
@vgtom Usually we don't have such a session, because it could overload me easily. If you have any questions, feel free to ask me here or on the slack/mail list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] vgtom commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
vgtom commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626110342
I would like to work on this issue!! Is there a chat forum where we can discuss??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jackiepon31 commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
jackiepon31 commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-644038511
i have read the source code of Skwalking for a while and i have made some comments on that,may be i can help you ,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] vgtom commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
vgtom commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626114710
is it possible to have a quick hangout/webex/zoom session to explain the code structure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626113681
@vgtom Welcome. I also noticed you have found the slack room. So, the mail list is the most official discussion in the Apache, if you just need quick discussion, slack and github issue are both fine. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4759:
URL: https://github.com/apache/skywalking/issues/4759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] vgtom commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
vgtom commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626468666
@wu-sheng ...ok i will try to join the meeting tomorrow at 0830 PM UTC+8 TZ...but i just started here and would have been nice if someone cud have guided me on the code structure or some videos perhaps...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] timandy commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
timandy commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-686999782
I have the same confuse. How to change the context path of skywalking-ui?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-687002517
> I have the same confuse. How to change the context path of skywalking-ui?
Off topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4759: not support springmvc [server.servlet.context-path]
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4759:
URL: https://github.com/apache/skywalking/issues/4759#issuecomment-626456725
@vgtom If you have subscribed to our dev mail list, I just send the invitation about that, we have a bi-weekly online meeting tomorrow night 0830 PM UTC+8 TZ. If you have any question, welcome to join. There are many discussion there in Mandarin, due to many of our users are, but feel free to use English, I will be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org