You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/12/17 20:07:14 UTC
[GitHub] [cassandra-dtest] aholmberg opened a new pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back
aholmberg opened a new pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109
CASSANDRA-16332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] dcapwell commented on a change in pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109#discussion_r546062947
##########
File path: upgrade_tests/cql_tests.py
##########
@@ -4122,6 +4122,7 @@ def test_static_columns_with_2i(self):
cursor.execute("CREATE INDEX ON test(v)")
+ from_ver = float(self.UPGRADE_PATH.starting_meta.family)
Review comment:
just checked, the following are current family versions
```
family='2.1'
family='3.0'
family='3.11'
family='trunk'
```
so the last one would break as trunk isn't a valid float.
What we can do is the following
after `self.prepare` do
```
initial_version = self.cluster.version()
```
then change the if check to
```
if initial_version > LooseVersion('3.0'):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] dcapwell commented on a change in pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109#discussion_r546057894
##########
File path: upgrade_tests/cql_tests.py
##########
@@ -4122,6 +4122,7 @@ def test_static_columns_with_2i(self):
cursor.execute("CREATE INDEX ON test(v)")
+ from_ver = float(self.UPGRADE_PATH.starting_meta.family)
Review comment:
can't family contain stuff like `x`? should we use LooseVersion like we do in other tests?
checking...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] aholmberg closed pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back
Posted by GitBox <gi...@apache.org>.
aholmberg closed pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] aholmberg commented on a change in pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back
Posted by GitBox <gi...@apache.org>.
aholmberg commented on a change in pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109#discussion_r546074978
##########
File path: upgrade_tests/cql_tests.py
##########
@@ -4122,6 +4122,7 @@ def test_static_columns_with_2i(self):
cursor.execute("CREATE INDEX ON test(v)")
+ from_ver = float(self.UPGRADE_PATH.starting_meta.family)
Review comment:
I can try that out. I didn't know any upgrade tests start with trunk. Is that a thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org