You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "jGauravGupta (via GitHub)" <gi...@apache.org> on 2025/08/22 17:58:55 UTC
[PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
jGauravGupta opened a new pull request, #8754:
URL: https://github.com/apache/netbeans/pull/8754
This PR corrects two Maven coordinates in
[`java/maven.embedder/external/binariesembedded-list`](https://github.com/apache/netbeans/blob/27/java/maven.embedder/external/binariesembedded-list).
#### Changes:
1. **JSpecify**
- Current:
```
org.jspecify.jspecify:jspecify:1.0.0
```
- Corrected:
```
org.jspecify:jspecify:1.0.0
```
- Reference: [Maven Central - org.jspecify:jspecify:1.0.0](https://mvnrepository.com/artifact/org.jspecify/jspecify/1.0.0)
---
2. **Guice**
- Current:
```
com.google.inject:guice:5.1.0-classes
```
- Corrected:
```
com.google.inject:guice:5.1.0
```
- Reference: [Maven Central - com.google.inject:guice:5.1.0](https://mvnrepository.com/artifact/com.google.inject/guice/5.1.0)
---
### Notes
These corrections align the coordinates with Maven Central and prevent potential build or dependency resolution issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8754:
URL: https://github.com/apache/netbeans/pull/8754#issuecomment-3222434438
@jGauravGupta thanks for the fixes. Btw how did you notice that the coordinates were not correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
Posted by "jGauravGupta (via GitHub)" <gi...@apache.org>.
jGauravGupta commented on PR #8754:
URL: https://github.com/apache/netbeans/pull/8754#issuecomment-3222474806
The project failed to build with RELEASE270:
🔗 https://github.com/jeddict/jeddict-ai
Commit reference:
🔗 https://github.com/jeddict/jeddict-ai/commit/0c6bafa4e9245e8aad5560d5da7d28fa0e4af42c
So I tweaked the configuration as follows:
````
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<version>5.1.0</version>
<scope>compile</scope>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>org.netbeans.modules</groupId>
<artifactId>org-netbeans-modules-maven-embedder</artifactId>
<version>RELEASE270</version>
<exclusions>
<exclusion>
<groupId>org.jspecify.jspecify</groupId>
<artifactId>jspecify</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8754:
URL: https://github.com/apache/netbeans/pull/8754#issuecomment-3226049380
thanks for sharing. This can help those who run into the same issue.
We should think about validating those coordinates during update. Will try to come up with something next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8754:
URL: https://github.com/apache/netbeans/pull/8754#discussion_r2294620662
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -25,9 +25,9 @@ EE45D1CF6EC2CC2B809FF04B4DC7AEC858E0DF8F;commons-codec:commons-codec:1.18.0
853CE06C11316B33A8EAE5E9095DA096A9528B8F;com.google.code.gson:gson:2.13.1
FC0AE991433E8590BA51CD558421478318A74C8C;com.google.errorprone:error_prone_annotations:2.38.0
E70A3268E6CD3E7D458AA15787CE6811C34E96AE;com.google.guava:guava:33.4.8-jre
-E7BA4C25BEC3761840F67C73F166C0D509D01D1D;com.google.inject:guice:5.1.0-classes
+E7BA4C25BEC3761840F67C73F166C0D509D01D1D;com.google.inject:guice:5.1.0
Review Comment:
this would have to be
```
E7BA4C25BEC3761840F67C73F166C0D509D01D1D;com.google.inject:guice:5.1.0:classes
```
i believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix incorrect Maven coordinates in `binariesembedded-list` (jspecify & guice) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8754:
URL: https://github.com/apache/netbeans/pull/8754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists