You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2018/05/03 09:01:16 UTC

[GitHub] flink issue #5939: [FLINK-8500] [Kafka Connector] Get the timestamp of the K...

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5939
  
    The feature is a nice addition.
    
    Flink currently already adds the timestamp as the record's event time timestamp. You can access it via a ProcessFunction. That is a tad bit more clumsy, though...
    
    If we want to have the timestamp as part of the Deserialization Schema, I would suggest to not add yet another specialized schema, but extend the KeyedDeserializationSchema with another method that takes the timestamp. We should make that a default method that calls the existing method and make the existing method an empty default method.
    
    We could also think about renaming `KeyedDeserializationSchema` to `RichDeserializationSchema` or so, if that would describe the functionality better (I am not a native speaker, so would be nice for one to give their opinion here).


---