You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/06/21 12:19:46 UTC

[GitHub] [phoenix-queryserver] stoty commented on a diff in pull request #95: PHOENIX-6737 PhoenixDB test environment update

stoty commented on code in PR #95:
URL: https://github.com/apache/phoenix-queryserver/pull/95#discussion_r902548049


##########
python-phoenixdb/requirements.txt:
##########
@@ -16,4 +16,4 @@
 # specific language governing permissions and limitations
 # under the License.
 #
-# requirements are defined in setup.py
+# requirements are defined in setup.py

Review Comment:
   From what I read about it, "hard" requirements should be specified in setup.py.
   You're totally right about the README



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org