You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/29 05:47:26 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #18681: Adjust the select sql statement in OracleParserStatementExample.
jiangML opened a new pull request, #18681:
URL: https://github.com/apache/shardingsphere/pull/18681
Fixes https://github.com/apache/shardingsphere/issues/18680
Changes proposed in this pull request:
- Adjust the select sql statement in OracleParserStatementExample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18681: Adjust the select sql statement in OracleParserStatementExample.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18681:
URL: https://github.com/apache/shardingsphere/pull/18681#issuecomment-1169581398
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18681](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (348b6cc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/07ce91748c8d080d3ba7e8305e0b39f30a4e5cd1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07ce917) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18681 +/- ##
============================================
- Coverage 59.37% 59.36% -0.01%
Complexity 2260 2260
============================================
Files 3734 3734
Lines 54830 54830
Branches 9338 9338
============================================
- Hits 32555 32552 -3
- Misses 19529 19532 +3
Partials 2746 2746
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/18681/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [07ce917...348b6cc](https://codecov.io/gh/apache/shardingsphere/pull/18681?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18681: Adjust the select sql statement in OracleParserStatementExample.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18681:
URL: https://github.com/apache/shardingsphere/pull/18681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #18681: Adjust the select sql statement in OracleParserStatementExample.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #18681:
URL: https://github.com/apache/shardingsphere/pull/18681#issuecomment-1172831172
Agree, in Oracle, table alias does not support `AS`, and `AS` is optional between column and column_alias.
Refer to [doc](https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/SELECT.html#GUID-CFA006CA-6FF1-4972-821E-6996142A51C6) and search `t_alias`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jiangML commented on pull request #18681: Adjust the select sql statement in OracleParserStatementExample.
Posted by GitBox <gi...@apache.org>.
jiangML commented on PR #18681:
URL: https://github.com/apache/shardingsphere/pull/18681#issuecomment-1172352035
The select syntax is explained on pages 345, 347, and 350 of oracle's official documentation https://download.oracle.com/otn_hosted_doc/timesten/703/TimesTen-Documentation/sql.pdf.
Oracle column aliases support AS, table aliases do not support AS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org