You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/12/22 19:34:17 UTC
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #84:
[WIP] - Guest network: Egress rules tab
RitchieVincent opened a new pull request #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Many tabs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-575087134
Thanks @RitchieVincent, reviewing/testing now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #84:
[WIP] - Guest network: Many tabs
Posted by GitBox <gi...@apache.org>.
RitchieVincent opened a new pull request #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570985031
@RitchieVincent is this ready for review and testing? Or, are you working on the security groups ingress/egress tabs as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570433793
@RitchieVincent alright, let me review and test this one. I don't see the SG (https://github.com/apache/cloudstack-primate/issues/49) tab changes with this PR nor another PR, so I suppose that's pending and would be submitted today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570408588
@rhtyd The rest of the guest network tabs should be complete now. There is a quite a lot of work involved in some of the tabs (load balancer especially). I've tested them as much as I can, but after working on them for quite a while a couple of bugs may have snuck in, so let me know if you spot any whilst testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Many tabs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-574028610
@RitchieVincent ping - kindly update status, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-568441827
> > Is this ready for review/testing @RitchieVincent - or should I wait if you're adding other custom actions from the other tickets?
>
> @rhtyd I completed it on Friday so I'll have a quick run through it now just to make sure I didn't miss anything. But I'll be adding the other tickets to this PR as well, so it's not ready for merging yet.
Should be all good to go now. Just added some minor mobile fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Many tabs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-573600724
@RitchieVincent as discussed over call, few issues:
- Show/hide VPN enable/disable button
- Listing/going to the resource view fails for project (see browser console for errors)
- Delete or list LB tab, loading continues
- Good to have a fix: Refreshing resource view, selected tab resets in some cases
- Add a new LB rule, add a VM to it, on refresh; VM list is empty
- Revisit the LB tab
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Many tabs
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-574661029
> @RitchieVincent no changes seen here, are you working on them at all? If not, please advise.
All fixes should be in place now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on a change in pull
request #84: [WIP] - Guest network: Many tabs
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on a change in pull request #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#discussion_r366863447
##########
File path: src/config/section/network.js
##########
@@ -47,7 +47,7 @@ export default {
}, {
name: 'Egress Rules',
component: () => import('@/views/network/EgressConfigure.vue'),
- show: record => record.service && record.service.filter(x => x.name === 'Firewall').length > 0
+ show: () => true
Review comment:
@rhtyd This line was the source of the issue with refreshing the page and the tab changing away from Egress. It's linked with the fact that there needs to be an API call before getting this info, so the tab is always hidden by default (whilst waiting for the data) so that when you click the refresh button, the tab isn't there, therefore making it unable to maintain that active tab state.
So the potential solution I've implemented is showing the tab at all times, and just displaying the default "No Data" message when there are no records that match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed pull request #84: [WIP] - Guest
network: Many tabs
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #84: Guest network:
Egress, PF, FW, VPN, LB
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #84: Guest network: Egress, PF, FW, VPN, LB
URL: https://github.com/apache/cloudstack-primate/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-568411742
> Is this ready for review/testing @RitchieVincent - or should I wait if you're adding other custom actions from the other tickets?
@rhtyd I completed it on Friday so I'll have a quick run through it now just to make sure I didn't miss anything. But I'll be adding the other tickets to this PR as well, so it's not ready for merging yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570023893
@RitchieVincent are you sending rest of the guest network tasks within this PR? I couldn't find them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-571302319
@rhtyd Please review the latest updates when you get the chance. All the issues you highlighted above should either be resolved, or were already resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] -
Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570543949
> * When a single rule is added, somehow the loading icons gets cut by the tab height being smaller than assumed by the `a-spin`? Please check/test the css?
Could I get some more info on this issue please? I'm unable to replicate this, I may just not fully understand where you mean the issue is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request
#84: [WIP] - Guest network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#discussion_r362689727
##########
File path: src/config/section/network.js
##########
@@ -186,14 +187,20 @@ export default {
columns: ['ipaddress', 'state', 'associatednetworkname', 'virtualmachinename', 'allocated', 'account', 'zonename'],
details: ['ipaddress', 'id', 'associatednetworkname', 'virtualmachinename', 'networkid', 'issourcenat', 'isstaticnat', 'virtualmachinename', 'vmipaddress', 'vlan', 'allocated', 'account', 'zonename'],
tabs: [{
- name: 'configure',
- component: () => import('@/views/network/IpConfigure.vue')
+ name: 'details',
+ component: () => import('@/components/view/DetailsTab.vue')
+ }, {
+ name: 'Firewall',
+ component: () => import('@/views/network/FirewallRules.vue')
+ }, {
+ name: 'Port Forwarding',
+ component: () => import('@/views/network/PortForwarding.vue')
+ }, {
+ name: 'Load Balancing',
Review comment:
@RitchieVincent add the `show()` methods for all these tabs, as discussed and described earlier see the individual issues tickets on what condition to check (for example, 'Firewall' in case of Firewall tab etc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Many tabs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-574523899
@RitchieVincent no changes seen here, are you working on them at all? If not, please advise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest
network: Egress rules tab
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-568371412
Is this ready for review/testing @RitchieVincent - or should I wait if you're adding other custom actions from the other tickets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services