You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ariesdevil (via GitHub)" <gi...@apache.org> on 2024/03/13 14:25:01 UTC
[PR] chore: update arrow-format [arrow-rs]
ariesdevil opened a new pull request, #5502:
URL: https://github.com/apache/arrow-rs/pull/5502
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Based on #5481 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Update arrow-format to new version.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Update arrow-format to new version, include `ListView`, `LargeListView`, `BinaryView` and `StringView`.
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1525724307
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -32,8 +32,7 @@ use arrow_ipc::writer;
use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit};
use crate::basic::{
- ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit,
Review Comment:
There are also code changes mixed in though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "RinChanNOWWW (via GitHub)" <gi...@apache.org>.
RinChanNOWWW commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1561932189
##########
arrow-ipc/src/gen/Message.rs:
##########
@@ -720,6 +726,33 @@ impl<'a> RecordBatch<'a> {
)
}
}
+ /// Some types such as Utf8View are represented using a variable number of buffers.
+ /// For each such Field in the pre-ordered flattened logical schema, there will be
+ /// an entry in variadicBufferCounts to indicate the number of number of variadic
Review Comment:
> the number of number of
Redundant words.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1525708035
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -32,8 +32,7 @@ use arrow_ipc::writer;
use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit};
use crate::basic::{
- ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit,
Review Comment:
The changes in this file seem unrelated to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1561955440
##########
arrow-ipc/src/gen/Message.rs:
##########
@@ -720,6 +726,33 @@ impl<'a> RecordBatch<'a> {
)
}
}
+ /// Some types such as Utf8View are represented using a variable number of buffers.
+ /// For each such Field in the pre-ordered flattened logical schema, there will be
+ /// an entry in variadicBufferCounts to indicate the number of number of variadic
Review Comment:
Should modify the fbs file https://github.com/apache/arrow-rs/blob/master/format/Message.fbs#L105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1525725539
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -32,8 +32,7 @@ use arrow_ipc::writer;
use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit};
use crate::basic::{
- ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update arrow-format [arrow-rs]
Posted by "ariesdevil (via GitHub)" <gi...@apache.org>.
ariesdevil commented on code in PR #5502:
URL: https://github.com/apache/arrow-rs/pull/5502#discussion_r1525712854
##########
parquet/src/arrow/schema/mod.rs:
##########
@@ -32,8 +32,7 @@ use arrow_ipc::writer;
use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit};
use crate::basic::{
- ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit,
Review Comment:
cargo formatted...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org