You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2024/07/19 08:46:56 UTC
[PR] [Cloud](Variant) support DESC merge variants's schema for cloud mode … [doris]
eldenmoon opened a new pull request, #38143:
URL: https://github.com/apache/doris/pull/38143
…(#37955)
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Cloud](Variant) support DESC merge variants's schema for cloud mode … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38143:
URL: https://github.com/apache/doris/pull/38143#issuecomment-2238682902
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Cloud](Variant) support DESC merge variants's schema for cloud mode … [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #38143:
URL: https://github.com/apache/doris/pull/38143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Cloud](Variant) support DESC merge variants's schema for cloud mode … [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #38143:
URL: https://github.com/apache/doris/pull/38143#discussion_r1684069735
##########
be/src/service/internal_service.cpp:
##########
@@ -1044,11 +1044,11 @@ struct AsyncRPCContext {
brpc::CallId cid;
};
-void PInternalServiceImpl::fetch_remote_tablet_schema(google::protobuf::RpcController* controller,
- const PFetchRemoteSchemaRequest* request,
- PFetchRemoteSchemaResponse* response,
- google::protobuf::Closure* done) {
- bool ret = _heavy_work_pool.try_offer([this, request, response, done]() {
+void PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController* controller,
Review Comment:
warning: function 'fetch_remote_tablet_schema' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
void PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController* controller,
^
```
<details>
<summary>Additional context</summary>
**be/src/service/internal_service.cpp:1046:** 96 lines including whitespace and comments (threshold 80)
```cpp
void PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcController* controller,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org