[GitHub] zhengruifeng commented on a change in pull request #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML

[GitBox <gi...@apache.org>]

zhengruifeng commented on a change in pull request #23144: [SPARK-26172][ML][WIP] Unify String Params' case-insensitivity in ML
URL: https://github.com/apache/spark/pull/23144#discussion_r245871966
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/param/params.scala
 ##########
 @@ -524,6 +525,65 @@ class BooleanParam(parent: String, name: String, doc: String) // No need for isV
   }
 }
 
+/**
+ * :: DeveloperApi ::
+ * Specialized version of `Param[String]` for Java.
+ */
+@DeveloperApi
 
 Review comment:
   this `normalize` is only added to `StringParam` extending `Param[String]`, so it will affect other type of params. 
   OK, I also feel it somewhat complex.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org