You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/02 17:36:02 UTC
[GitHub] [spark] sarutak opened a new pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
sarutak opened a new pull request #31442:
URL: https://github.com/apache/spark/pull/31442
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR change sthe type mapping for `money` and `money[]` types for PostgreSQL.
Currently, those types are tried to convert to `DoubleType` and `ArrayType` of `double` respectively.
But the JDBC driver seems not to be able to handle those types properly.
https://github.com/pgjdbc/pgjdbc/issues/100
https://github.com/pgjdbc/pgjdbc/issues/1405
Due to these issue, we can get the error like as follows.
money type.
```
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0) (192.168.1.204 executor driver): org.postgresql.util.PSQLException: Bad value for type double : 1,000.00
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.PgResultSet.getDouble(PgResultSet.java:2432)
[info] at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.$anonfun$makeGetter$5(JdbcUtils.scala:418)
```
money[] type.
```
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0) (192.168.1.204 executor driver): org.postgresql.util.PSQLException: Bad value for type double : $2,000.00
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.ArrayDecoding$5.parseValue(ArrayDecoding.java:235)
[info] at org.postgresql.jdbc.ArrayDecoding$AbstractObjectStringArrayDecoder.populateFromString(ArrayDecoding.java:122)
[info] at org.postgresql.jdbc.ArrayDecoding.readStringArray(ArrayDecoding.java:764)
[info] at org.postgresql.jdbc.PgArray.buildArray(PgArray.java:310)
[info] at org.postgresql.jdbc.PgArray.getArrayImpl(PgArray.java:171)
[info] at org.postgresql.jdbc.PgArray.getArray(PgArray.java:111)
```
For money type, a known workaround is to treat it as string so this PR do it.
For money[], however, there is no reasonable workaround so this PR remove the support.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This is a bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. As of this PR merged, money type is mapped to `StringType` rather than `DoubleType` and the support for money[] is stopped.
For money type, if the value is less than one thousand, `$100.00` for instance, it works so I also updated the migration guide.
On the other hand, money[] seems not to work with any value but mentioned in the migration guide just in case.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775656109
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39642/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775656122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39642/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r569634360
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, money type in PostgreSQL table is converted to `StringType` and money[] type is not supported due to the JDBC driver for PostgreSQL can't handle those types properly.
Review comment:
> Why not a string array for a money array?
For money type, Spark SQL calls `PgResultSet.getDouble` causing the error.
```
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0) (192.168.1.204 executor driver): org.postgresql.util.PSQLException: Bad value for type double : 1,000.00
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.PgResultSet.getDouble(PgResultSet.java:2432)
[info] at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.$anonfun$makeGetter$5(JdbcUtils.scala:418)
```
So, we can avoid this issue by mapping money type to `StringType` to let Spark SQL call `getString` rather than `getDouble`.
For money[] type, on the other hand, the PostgreSQL's JDBC driver calls `PgResultSet.toDouble` internally.
```
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.ArrayDecoding$5.parseValue(ArrayDecoding.java:235)
[info] at org.postgresql.jdbc.ArrayDecoding$AbstractObjectStringArrayDecoder.populateFromString(ArrayDecoding.java:122)
[info] at org.postgresql.jdbc.ArrayDecoding.readStringArray(ArrayDecoding.java:764)
```
We can control how Spark SQL gets the value from the array obtained by `PgResultSet.getArray`, but it's difficult to control how the JDBC driver handles the elements in the array which is to be returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775636311
**[Test build #135060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135060/testReport)** for PR 31442 at commit [`c63121a`](https://github.com/apache/spark/commit/c63121abe9f86dd629a8169e431f846442430dbb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771933680
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776476511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39673/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r572527343
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, money type in PostgreSQL table is converted to `StringType` and money[] type is not supported due to the JDBC driver for PostgreSQL can't handle those types properly.
Review comment:
Thanks. I've updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776503691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135091/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776476511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39673/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775656122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39642/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776503691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135091/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771857295
**[Test build #134793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134793/testReport)** for PR 31442 at commit [`59dbb59`](https://github.com/apache/spark/commit/59dbb5935998e14c74de39de9f6bd469a4d0912a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776430570
**[Test build #135091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135091/testReport)** for PR 31442 at commit [`b838218`](https://github.com/apache/spark/commit/b83821806c87ba6d710efe604a7c9d270af9617b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-780299732
Thank you, @sarutak and all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776418535
Could you resolve the conflict? Looks fine otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771857295
**[Test build #134793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134793/testReport)** for PR 31442 at commit [`59dbb59`](https://github.com/apache/spark/commit/59dbb5935998e14c74de39de9f6bd469a4d0912a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771883558
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775728950
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135060/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-780239801
Merged to `master`. Thanks all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-774858990
cc: @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-779540042
If there is no objection, I'll merge soon.
If we find that the word `dialect` in the migration guide is an internal term, I'll open another PR to fix all the occurrence in the guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776452940
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39673/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r573847089
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, PostgreSQL JDBC dialect uses StringType for MONEY and MONEY[] is not supported due to the JDBC driver for PostgreSQL can't handle those types properly. In Spark 3.1 or earlier, DoubleType and ArrayType of DoubleType are used respectively.
Review comment:
I've replied at https://github.com/apache/spark/pull/31491#discussion_r573846295 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776430570
**[Test build #135091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135091/testReport)** for PR 31442 at commit [`b838218`](https://github.com/apache/spark/commit/b83821806c87ba6d710efe604a7c9d270af9617b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776491691
**[Test build #135091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135091/testReport)** for PR 31442 at commit [`b838218`](https://github.com/apache/spark/commit/b83821806c87ba6d710efe604a7c9d270af9617b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771977982
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134793/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771857295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771933680
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775636311
**[Test build #135060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135060/testReport)** for PR 31442 at commit [`c63121a`](https://github.com/apache/spark/commit/c63121abe9f86dd629a8169e431f846442430dbb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775094701
LGTM except one comment about migration guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #31442:
URL: https://github.com/apache/spark/pull/31442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771933680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r569467189
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, money type in PostgreSQL table is converted to `StringType` and money[] type is not supported due to the JDBC driver for PostgreSQL can't handle those types properly.
Review comment:
Yeah, DecimalType fixes the accuracy problem with money, but can't account for units. I suppose we could one day support it as a struct of DecimalType and StringType for currency, but string seems fine now.
Why not a string array for a money array?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776460281
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39673/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r575974118
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, PostgreSQL JDBC dialect uses StringType for MONEY and MONEY[] is not supported due to the JDBC driver for PostgreSQL can't handle those types properly. In Spark 3.1 or earlier, DoubleType and ArrayType of DoubleType are used respectively.
Review comment:
@maropu Any more concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771857295
**[Test build #134793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134793/testReport)** for PR 31442 at commit [`59dbb59`](https://github.com/apache/spark/commit/59dbb5935998e14c74de39de9f6bd469a4d0912a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r569634360
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, money type in PostgreSQL table is converted to `StringType` and money[] type is not supported due to the JDBC driver for PostgreSQL can't handle those types properly.
Review comment:
> Why not a string array for a money array?
For money type, Spark SQL calls `PgResultSet.getDouble` causing the error.
```
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0) (192.168.1.204 executor driver): org.postgresql.util.PSQLException: Bad value for type double : 1,000.00
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.PgResultSet.getDouble(PgResultSet.java:2432)
[info] at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.$anonfun$makeGetter$5(JdbcUtils.scala:418)
```
So, we can avoid this issue by mapping money type to `StringType` to let Spark SQL call `getString` rather than `getDouble`.
For money[] type, on the other hand, the PostgreSQL's JDBC driver calls `PgResultSet.toDouble` internally.
```
[info] at org.postgresql.jdbc.PgResultSet.toDouble(PgResultSet.java:3104)
[info] at org.postgresql.jdbc.ArrayDecoding$5.parseValue(ArrayDecoding.java:235)
[info] at org.postgresql.jdbc.ArrayDecoding$AbstractObjectStringArrayDecoder.populateFromString(ArrayDecoding.java:122)
[info] at org.postgresql.jdbc.ArrayDecoding.readStringArray(ArrayDecoding.java:764)
```
We can control how Spark SQL get the value from the array obtained by `PgResultSet.getArray`, but it's difficult to control how the JDBC driver handles the elements in the array which is to be returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771977982
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134793/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r573736731
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, PostgreSQL JDBC dialect uses StringType for MONEY and MONEY[] is not supported due to the JDBC driver for PostgreSQL can't handle those types properly. In Spark 3.1 or earlier, DoubleType and ArrayType of DoubleType are used respectively.
Review comment:
I have the same comment here with https://github.com/apache/spark/pull/31491#discussion_r573709268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771907378
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r571990570
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, money type in PostgreSQL table is converted to `StringType` and money[] type is not supported due to the JDBC driver for PostgreSQL can't handle those types properly.
Review comment:
In the migration guide, we should also mention the previous behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775728950
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135060/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775717103
**[Test build #135060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135060/testReport)** for PR 31442 at commit [`c63121a`](https://github.com/apache/spark/commit/c63121abe9f86dd629a8169e431f846442430dbb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31442:
URL: https://github.com/apache/spark/pull/31442#discussion_r573431597
##########
File path: docs/sql-migration-guide.md
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Spark SQL 3.1 to 3.2
+ - In Spark 3.2, PostgreSQL JDBC dialect uses StringType for MONEY and MONEY[] is not supported due to the JDBC driver for PostgreSQL can't handle those types properly. Previously, DoubleType and ArrayType of DoubleType are used respectively.
Review comment:
nit: `Previously, ` => `In Spark 3.1 or earlier,`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771933680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-775646424
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39642/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-771968796
**[Test build #134793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134793/testReport)** for PR 31442 at commit [`59dbb59`](https://github.com/apache/spark/commit/59dbb5935998e14c74de39de9f6bd469a4d0912a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31442:
URL: https://github.com/apache/spark/pull/31442#issuecomment-776427904
@maropu Thanks. I've updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org