[jira] [Updated] (HDFS-5409) TestOfflineEditsViewer#testStored fails on Windows due to CRLF line endings in editsStored.xml from git checkout

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HDFS-5409:
--------------------------------

    Attachment: HDFS-5409.1.patch

This patch rewrites the assertion to do a text comparison instead of a binary comparison.  This will ignore line ending differences.  I verified this on Mac and Windows.

> TestOfflineEditsViewer#testStored fails on Windows due to CRLF line endings in editsStored.xml from git checkout
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5409
>                 URL: https://issues.apache.org/jira/browse/HDFS-5409
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-5409.1.patch
>
>
> When doing a git checkout on Windows, hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored.xml has CRLF line endings.  The offline edits viewer tool generates XML output with LF line endings.  This causes {{TestOfflineEditsViewer#testStored}} to fail when asserting that editsStored.xml and editsStoredParsed.xml have the same content.



--
This message was sent by Atlassian JIRA
(v6.2#6252)