[jira] [Comment Edited] (PHOENIX-1846) Add MINUTE built-in function

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490796#comment-14490796 ] 

James Taylor edited comment on PHOENIX-1846 at 4/11/15 5:25 AM:
----------------------------------------------------------------

Thanks for the patch, [~ayingshu]. Same minor comments as with the other one:
- Always add built-in functions to the end of the ExpressionType enum. Don't worry about them not being grouped with the other date/time functions
- Upsert a few more rows to make sure every row isn't being matched.



was (Author: jamestaylor):
Thanks for the patch, [~ayingshu]. Same minor comments as with the other one:
- Always add built-in functions to the end of the ExpressionType enum. Don't worry about them not being grouped with the other date/time functions
- Upsert a few more values to make sure every row isn't being matched.


> Add MINUTE built-in function
> ----------------------------
>
>                 Key: PHOENIX-1846
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1846
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Alex Warshavsky
>         Attachments: Phoenix-1846.patch
>
>
> Add MINUTE(date/time/timestamp) function: An integer from 0 to 59 representing the minute component of time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)