You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/23 14:40:11 UTC
[GitHub] [incubator-shardingsphere] haetao opened a new pull request #4420:
Add delete branch contribution guide to doc
haetao opened a new pull request #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420
Fixes #4419 .
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4420: Add
delete branch contribution guide to doc
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420#issuecomment-590081871
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=h1) Report
> Merging [#4420](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/33acaa6bb363db6e9126fbcf5ede7bd8b20fea2e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4420 +/- ##
========================================
Coverage 55% 55%
Complexity 332 332
========================================
Files 958 958
Lines 18478 18478
Branches 3417 3417
========================================
Hits 10164 10164
Misses 7655 7655
Partials 659 659
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=footer). Last update [33acaa6...53b1afa](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4420?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4420: Add delete branch contribution guide to doc
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420#issuecomment-590077380
## Pull Request Test Coverage Report for [Build 9725](https://coveralls.io/builds/28904758)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **58.637%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28904758/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28904758) |
| :-- | --: |
| Change from base [Build 911](https://coveralls.io/builds/28902107): | -0.005% |
| Covered Lines: | 10835 |
| Relevant Lines: | 18478 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4420: Add
delete branch contribution guide to doc
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420#issuecomment-590077380
## Pull Request Test Coverage Report for [Build 9724](https://coveralls.io/builds/28904449)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **58.637%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28904449/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28904449) |
| :-- | --: |
| Change from base [Build 911](https://coveralls.io/builds/28902107): | -0.005% |
| Covered Lines: | 10835 |
| Relevant Lines: | 18478 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4420: Add
delete branch contribution guide to doc
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #4420: Add delete branch contribution guide to doc
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4420: Add delete branch contribution guide to doc
URL: https://github.com/apache/incubator-shardingsphere/pull/4420#discussion_r383012816
##########
File path: docs/community/content/contribute/contributor.en.md
##########
@@ -61,6 +61,16 @@ git push origin issueNo
- The mentor will do code review before discussing some details (including the design, the implementation and the performance) with you. The request will be merged into the branch of current development version after the edit is well enough.
- At last, congratulate to be an official contributor of ShardingSphere
+### Delete Branch
+
+ - You can delete the remote branch (origin/issueNo) and the local branch (issueNo) associated with the remote branch (origin/issueNo) after the mentor merged the pull request into the master branch of shardingsphere.
Review comment:
`shardingsphere` should be `ShardingSphere `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services