You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/03 17:06:45 UTC
[GitHub] [maven-surefire] isaki opened a new pull request #304: SUREFIRE-1815: Interrupt state handling in output
isaki opened a new pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304
Added a restoration of thread interrupt state to LegacyMasterProcessChannelEncoder. Added a unit test to ensure this is indeed fixed and not reintroduced.
https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304#issuecomment-654317462
@isaki
Thx for contributing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] isaki commented on pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
isaki commented on pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304#issuecomment-654319209
You are welcome! I look forward to being able to upgrade from 3.0.0-M4 once there is a new build available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304#discussion_r449751554
##########
File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java
##########
@@ -334,6 +333,14 @@ private void encodeAndPrintEvent( StringBuilder event, boolean sendImmediately )
.dumpException( e );
}
}
+ finally
+ {
+ // SUREFIRE-1815: We need to restore the interrupted state.
Review comment:
remove comments
we have git history
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] isaki commented on a change in pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
isaki commented on a change in pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304#discussion_r450305671
##########
File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java
##########
@@ -334,6 +333,14 @@ private void encodeAndPrintEvent( StringBuilder event, boolean sendImmediately )
.dumpException( e );
}
}
+ finally
+ {
+ // SUREFIRE-1815: We need to restore the interrupted state.
Review comment:
Done.
##########
File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java
##########
@@ -1090,6 +1090,36 @@ public void shouldHandleExitWithTrimmedTrace() throws IOException
.startsWith( ":maven-surefire-event:jvm-exit-error:UTF-8:MQ==:Mg==:NA==:" );
}
+ @Test
+ public void testInterruptHandling() throws IOException
+ {
+ // SUREFIRE-1815
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #304: SUREFIRE-1815: Interrupt state handling in output
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #304:
URL: https://github.com/apache/maven-surefire/pull/304#discussion_r449751570
##########
File path: surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java
##########
@@ -1090,6 +1090,36 @@ public void shouldHandleExitWithTrimmedTrace() throws IOException
.startsWith( ":maven-surefire-event:jvm-exit-error:UTF-8:MQ==:Mg==:NA==:" );
}
+ @Test
+ public void testInterruptHandling() throws IOException
+ {
+ // SUREFIRE-1815
Review comment:
the same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org