[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1221: DISPATCH-1986: Retry creating TestServer instance if port is already …

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1221:
URL: https://github.com/apache/qpid-dispatch/pull/1221#discussion_r634381208



##########
File path: tests/http1_tests.py
##########
@@ -272,13 +273,11 @@ def http1_ping(sport, cport):
         ]
     }
 
-    server = TestServer(server_port=sport,
-                        client_port=cport,
-                        tests=TEST)
+    server = wait_server_starting(sport, cport, TEST)

Review comment:
       The tests bring up and bring down the TestServer (in some cases 2 test servers). The TestServer(s) seem to shut down successfully but the port is not released on time before the next test comes along and starts the next TestServer on the same port(s). This fix will wait for the few seconds until the port is released. Could take more than a few seconds for the port to be released but that is something I have not seen yet. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org