You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/22 22:33:28 UTC
[GitHub] [pinot] jadami10 opened a new pull request #8387: add segment size metric on segment push
jadami10 opened a new pull request #8387:
URL: https://github.com/apache/pinot/pull/8387
## Description
<!-- Add a description of your PR here.
Adds an offline segment size metric only when a new segment is pushed. this is stored as a gauge and based on table name. This is useful to build detectors in case:
- someone tries to push a segment that is too large
- your segments are organically growing in size and you want to know once you've hit a threshold
I tested this by deploying this change to one of our clusters, manually uploading a CSV file, and observing the metric in our metrics platform.
-->
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8387: add segment size metric on segment push
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8387:
URL: https://github.com/apache/pinot/pull/8387#discussion_r832689513
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
##########
@@ -69,6 +69,10 @@
// Estimated size of offline table
OFFLINE_TABLE_ESTIMATED_SIZE("OfflineTableEstimatedSize", false),
+ // Size of an uploaded offline segment
+ OFFLINE_SEGMENT_SIZE("OfflineSegmentSize", false),
Review comment:
Let's name it `LAST_PUSHED_SEGMENT_SIZE` to be more specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on a change in pull request #8387: add segment size metric on segment push
Posted by GitBox <gi...@apache.org>.
jadami10 commented on a change in pull request #8387:
URL: https://github.com/apache/pinot/pull/8387#discussion_r832694704
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java
##########
@@ -69,6 +69,10 @@
// Estimated size of offline table
OFFLINE_TABLE_ESTIMATED_SIZE("OfflineTableEstimatedSize", false),
+ // Size of an uploaded offline segment
+ OFFLINE_SEGMENT_SIZE("OfflineSegmentSize", false),
Review comment:
great suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #8387: add segment size metric on segment push
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #8387:
URL: https://github.com/apache/pinot/pull/8387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on pull request #8387: add segment size metric on segment push
Posted by GitBox <gi...@apache.org>.
jadami10 commented on pull request #8387:
URL: https://github.com/apache/pinot/pull/8387#issuecomment-1075732335
> Let's add some release notes on this added metrics.
added. let me know if it's sufficient, please?
> Also note that different controller will have their own gauge value based on the segment uploaded to them
that's ok for us as we can aggregate the metric across dimension that do not include the controller host. any concerns on your end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org