You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Daniel John Debrunner (JIRA)" <de...@db.apache.org> on 2006/08/11 19:52:15 UTC

[jira] Created: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
-------------------------------------------------------------------------------------------------------

                 Key: DERBY-1674
                 URL: http://issues.apache.org/jira/browse/DERBY-1674
             Project: Derby
          Issue Type: Improvement
          Components: SQL
            Reporter: Daniel John Debrunner
         Assigned To: Daniel John Debrunner
            Priority: Minor


Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)

Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
that is done today (e.g. converting a descriptor to and from a Row object).

In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel John Debrunner reassigned DERBY-1674:
--------------------------------------------

    Assignee:     (was: Daniel John Debrunner)

Only working on the sub-task DERBY-1734 at the moment.

> Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1674
>                 URL: https://issues.apache.org/jira/browse/DERBY-1674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>            Priority: Minor
>
> Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)
> Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
> that is done today (e.g. converting a descriptor to and from a Row object).
> In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
> Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1674?page=comments#action_12430607 ] 
            
Rick Hillegas commented on DERBY-1674:
--------------------------------------

Merge DERBY-1674 (434100) to 10.2 at subversion revision 436921.

> Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1674
>                 URL: http://issues.apache.org/jira/browse/DERBY-1674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>         Assigned To: Daniel John Debrunner
>            Priority: Minor
>
> Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)
> Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
> that is done today (e.g. converting a descriptor to and from a Row object).
> In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
> Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1674?page=comments#action_12430588 ] 
            
Rick Hillegas commented on DERBY-1674:
--------------------------------------

Merge DERBY-1674 (433688, 433685, 433655, 433632) to 10.2 branch. Committed at subversion revision 436905.

> Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1674
>                 URL: http://issues.apache.org/jira/browse/DERBY-1674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>         Assigned To: Daniel John Debrunner
>            Priority: Minor
>
> Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)
> Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
> that is done today (e.g. converting a descriptor to and from a Row object).
> In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
> Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1674?page=comments#action_12429501 ] 
            
Daniel John Debrunner commented on DERBY-1674:
----------------------------------------------

Simple stats on class count and sizes in insane mode (from the classes folder, not size in the jar).
Revision: 432856
Number of RowFactory classes 21
Size of RowFactory classes 169252
org/apache/derby/iapi/sql/dictionary
Number of Dictionary api classes 47
Size of Dictionary api classes 216108
org/apache/derby/impl/sql/catalog
Number of Catalog impl classes 36
Size of Catalog impl classes 360173

> Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1674
>                 URL: http://issues.apache.org/jira/browse/DERBY-1674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>         Assigned To: Daniel John Debrunner
>            Priority: Minor
>
> Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)
> Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
> that is done today (e.g. converting a descriptor to and from a Row object).
> In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
> Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DERBY-1674) Investigate reducing the number of classes & methods in DataDictionary used to represent system tables

Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1674?page=comments#action_12429571 ] 
            
Daniel John Debrunner commented on DERBY-1674:
----------------------------------------------

Correct stats for an insane build:
Revision: 433398
Number of RowFactory classes 21
Size of RowFactory classes 126750
org/apache/derby/iapi/sql/dictionary
Number of Dictionary api classes 46
Size of Dictionary api classes 159707
org/apache/derby/impl/sql/catalog
Number of Catalog impl classes 37
Size of Catalog impl classes 268842

> Investigate reducing the number of classes & methods  in DataDictionary used to represent system tables
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1674
>                 URL: http://issues.apache.org/jira/browse/DERBY-1674
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Daniel John Debrunner
>         Assigned To: Daniel John Debrunner
>            Priority: Minor
>
> Currently two classes exists for each system table, one to represent the table (e.g.SYSTABLESRowFactory) , one to represent a row (e.g. TableDescriptor)
> Look at having a single row factory (CatalogRowFactory) and using polymorphism (method overloading) on the descriptor objects to perform the work
> that is done today (e.g. converting a descriptor to and from a Row object).
> In addition the DataDictionary has a specific method to drop each type of unique descriptor (e.g. dropSPSDescriptor, dropAliasDescriptor)
> Would it be possible to have a single dropDescriptor(UniqueSQLObjectDescriptor) method and again use polymorphism  on the descriptors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira