[GitHub] [incubator-doris] HappenLee commented on a change in pull request #5713: [Bug] Fix dead lock in olap scan node and refactor some code in FE profile

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #5713:
URL: https://github.com/apache/incubator-doris/pull/5713#discussion_r622014231



##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -1470,12 +1470,12 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
 
     _scan_cpu_timer->update(cpu_watch.elapsed_time());
     _scanner_wait_worker_timer->update(wait_time);
-    _scan_batch_added_cv.notify_one();
 
     // The transfer thead will wait for `_running_thread==0`, to make sure all scanner threads won't access class members.
     // Do not access class members after this code.
     std::unique_lock<std::mutex> l(_scan_batches_lock);
     _running_thread--;
+    _scan_batch_added_cv.notify_one();

Review comment:
       OK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org