You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2016/11/19 18:36:08 UTC
[4/6] [text] Add missing '@Override' annotations
Add missing '@Override' annotations
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/eb5e153f
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/eb5e153f
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/eb5e153f
Branch: refs/heads/master
Commit: eb5e153fd119d7f5125f5142dd6627f5355eb15d
Parents: aca047e
Author: Gary Gregory <gg...@apache.org>
Authored: Sat Nov 19 10:33:11 2016 -0800
Committer: Gary Gregory <gg...@apache.org>
Committed: Sat Nov 19 10:33:11 2016 -0800
----------------------------------------------------------------------
.../java/org/apache/commons/text/diff/ReplacementsFinder.java | 3 +++
.../java/org/apache/commons/text/similarity/EditDistance.java | 1 +
.../commons/text/similarity/LevenshteinDetailedDistance.java | 1 +
.../org/apache/commons/text/similarity/LevenshteinDistance.java | 1 +
.../java/org/apache/commons/text/diff/StringsComparatorTest.java | 3 +++
.../text/similarity/ParameterizedEditDistanceFromTest.java | 1 +
.../text/similarity/ParameterizedSimilarityScoreFromTest.java | 1 +
7 files changed, 11 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/main/java/org/apache/commons/text/diff/ReplacementsFinder.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/diff/ReplacementsFinder.java b/src/main/java/org/apache/commons/text/diff/ReplacementsFinder.java
index 02aff5f..d58d460 100644
--- a/src/main/java/org/apache/commons/text/diff/ReplacementsFinder.java
+++ b/src/main/java/org/apache/commons/text/diff/ReplacementsFinder.java
@@ -84,6 +84,7 @@ public class ReplacementsFinder<T> implements CommandVisitor<T> {
*
* @param object object to insert
*/
+ @Override
public void visitInsertCommand(final T object) {
pendingInsertions.add(object);
}
@@ -97,6 +98,7 @@ public class ReplacementsFinder<T> implements CommandVisitor<T> {
*
* @param object synchronization object detected
*/
+ @Override
public void visitKeepCommand(final T object) {
if (pendingDeletions.isEmpty() && pendingInsertions.isEmpty()) {
++skipped;
@@ -113,6 +115,7 @@ public class ReplacementsFinder<T> implements CommandVisitor<T> {
*
* @param object object to delete
*/
+ @Override
public void visitDeleteCommand(final T object) {
pendingDeletions.add(object);
}
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/main/java/org/apache/commons/text/similarity/EditDistance.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/similarity/EditDistance.java b/src/main/java/org/apache/commons/text/similarity/EditDistance.java
index fd6a024..35571e0 100644
--- a/src/main/java/org/apache/commons/text/similarity/EditDistance.java
+++ b/src/main/java/org/apache/commons/text/similarity/EditDistance.java
@@ -52,6 +52,7 @@ public interface EditDistance<R> extends SimilarityScore<R> {
* @param right the second CharSequence
* @return the similarity score between two CharSequences
*/
+ @Override
R apply(CharSequence left, CharSequence right);
}
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java b/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java
index c2f5911..a913a12 100644
--- a/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java
+++ b/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java
@@ -96,6 +96,7 @@ public class LevenshteinDetailedDistance implements EditDistance<LevenshteinResu
* @return result distance, or -1
* @throws IllegalArgumentException if either String input {@code null}
*/
+ @Override
public LevenshteinResults apply(final CharSequence left, final CharSequence right) {
if (threshold != null) {
return limitedCompare(left, right, threshold);
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java b/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
index b41abcb..c904adc 100644
--- a/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
+++ b/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java
@@ -104,6 +104,7 @@ public class LevenshteinDistance implements EditDistance<Integer> {
* @return result distance, or -1
* @throws IllegalArgumentException if either String input {@code null}
*/
+ @Override
public Integer apply(final CharSequence left, final CharSequence right) {
if (threshold != null) {
return limitedCompare(left, right, threshold);
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java b/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java
index 9c03ff1..2a4178d 100644
--- a/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java
+++ b/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java
@@ -56,12 +56,15 @@ public class StringsComparatorTest {
public ExecutionVisitor() {
v = new StringBuilder();
}
+ @Override
public void visitInsertCommand(final T object) {
v.append(object);
}
+ @Override
public void visitKeepCommand(final T object) {
v.append(object);
}
+ @Override
public void visitDeleteCommand(final T object) {
}
public String getString() {
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java
index 1dadc9a..b3d3ae5 100644
--- a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java
+++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java
@@ -68,6 +68,7 @@ public class ParameterizedEditDistanceFromTest<R> {
{
new EditDistance<Boolean>() {
+ @Override
public Boolean apply(final CharSequence left, final CharSequence right) {
return left == right || (left != null && left.equals(right));
}
http://git-wip-us.apache.org/repos/asf/commons-text/blob/eb5e153f/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java
index 2594731..0ac3ea2 100644
--- a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java
+++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java
@@ -44,6 +44,7 @@ public class ParameterizedSimilarityScoreFromTest<R> {
{
new SimilarityScore<Boolean>() {
+ @Override
public Boolean apply(final CharSequence left, final CharSequence right) {
return left == right || (left != null && left.equals(right));
}