[jira] [Resolved] (IMPALA-8626) JDBC tests don't seem to be using HTTP

["Thomas Tauber-Marshall (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Tauber-Marshall resolved IMPALA-8626.
--------------------------------------------
    Resolution: Not A Problem

> JDBC tests don't seem to be using HTTP
> --------------------------------------
>
>                 Key: IMPALA-8626
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8626
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.3.0
>            Reporter: Tim Armstrong
>            Assignee: Thomas Tauber-Marshall
>            Priority: Blocker
>
> I noticed that the parameterized JDBC tests are passing on the dockerised cluster, which shouldn't be possible because IMPALA-8623 isn't done.
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/453/testReport/org.apache.impala.service/JdbcTest/
> The connection strings look identical in both cases:
> {noformat}
> 19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
> {noformat}
> {noformat}
> 19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
> {noformat}
> I was looking at related code and saw some misuse of == vs equals() for string comparison here https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java#L172
> {code}
>   private static String getConnectionStr(String connType, String authStr) {
>     String connString = DEFAULT_CONNECTION_TEMPLATE + authStr;
>     if (connType == "binary") {
>       return String.format(connString, HS2_BINARY_PORT);
>     } else {
>       Preconditions.checkState(connType == "http");
>       return String.format(connString + HTTP_TRANSPORT_SPEC, HS2_HTTP_PORT);
>     }
> }
> {code}
> But I don't think that explains what I'm seeing above.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)