You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/06/17 00:24:53 UTC
Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java
files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21080/#review45844
-----------------------------------------------------------
Ship it!
Awesome Bernardo - sorry for the delay. Let us get this in.
src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/21080/#comment80840>
Please scan the patch for trailing spaces :-)
src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/21080/#comment80838>
Format is // TODO(vinod:
src/java/src/org/apache/mesos/Log.java
<https://reviews.apache.org/r/21080/#comment80836>
Capitalize first character here and everywhere else :-)
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/21080/#comment80837>
See comment above.
- Niklas Nielsen
On May 16, 2014, 3:55 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21080/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 3:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1302
> https://issues.apache.org/jira/browse/MESOS-1302
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files.
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/AbstractState.java 774b2176f9ec92c2e9c64470e3415d9e03a97c59
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21080/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>