You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2023/12/01 02:54:13 UTC

[PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

bobhan1 opened a new pull request, #27853:
URL: https://github.com/apache/doris/pull/27853

   ## Proposed changes
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835381728

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835378550

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1844778147

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835376675

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1848507955

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1845205536

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.2 seconds
    stream load tsv:          589 seconds loaded 74807831229 Bytes, about 121 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
    storage size: 17212015383 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1836203492

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835841015

   add testcase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1836203577

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen merged PR #27853:
URL: https://github.com/apache/doris/pull/27853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1843167599

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1843308849

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.24 seconds
    stream load tsv:          577 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.5 seconds inserted 10000000 Rows, about 350K ops/s
    storage size: 17194917475 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835453602

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 43.91 seconds
    stream load tsv:          559 seconds loaded 74807831229 Bytes, about 127 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17166792550 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1835504848

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 19be424e2a0e32688f5ec49bebac7846f4424df7, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4936	4707	4678	4678
   q2	351	163	157	157
   q3	1524	1379	1296	1296
   q4	1146	974	981	974
   q5	3252	3238	3237	3237
   q6	255	133	131	131
   q7	1044	533	596	533
   q8	2225	2265	2246	2246
   q9	7044	7020	7067	7020
   q10	3301	3365	3362	3362
   q11	346	214	213	213
   q12	357	214	226	214
   q13	4630	3903	3850	3850
   q14	260	217	222	217
   q15	618	537	516	516
   q16	433	417	377	377
   q17	1040	635	576	576
   q18	8026	7280	7259	7259
   q19	1562	1568	1542	1542
   q20	570	346	329	329
   q21	3447	2916	2978	2916
   q22	374	305	309	305
   Total cold run time: 46741 ms
   Total hot run time: 41948 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4606	4595	4592	4592
   q2	314	197	218	197
   q3	3725	3704	3711	3704
   q4	2528	2534	2480	2480
   q5	6107	6116	6091	6091
   q6	243	127	128	127
   q7	2620	1969	1955	1955
   q8	3724	3667	3715	3667
   q9	9489	9436	9462	9436
   q10	4050	4114	4138	4114
   q11	639	489	496	489
   q12	815	626	640	626
   q13	4374	3644	3697	3644
   q14	293	244	254	244
   q15	598	530	534	530
   q16	559	463	499	463
   q17	2126	2051	2077	2051
   q18	9325	8758	8916	8758
   q19	1815	1777	1777	1777
   q20	2315	2000	1987	1987
   q21	7253	7167	7040	7040
   q22	649	582	554	554
   Total cold run time: 68167 ms
   Total hot run time: 64526 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1843135988

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1849463342

   run pipelinex_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1845122392

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1845134219

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1845297512

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 523befcbc20c5b28a2c9b8a927d6f3f18f938c55, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4698	4474	4440	4440
   q2	376	143	158	143
   q3	1464	1223	1209	1209
   q4	1122	931	886	886
   q5	3195	3177	3170	3170
   q6	250	130	128	128
   q7	1018	497	491	491
   q8	2168	2223	2178	2178
   q9	6709	6616	6654	6616
   q10	3224	3278	3267	3267
   q11	316	212	209	209
   q12	349	214	214	214
   q13	4572	3878	3781	3781
   q14	244	216	211	211
   q15	568	531	518	518
   q16	444	389	385	385
   q17	1019	588	589	588
   q18	7561	6955	7581	6955
   q19	1511	1437	1392	1392
   q20	505	314	326	314
   q21	3141	2622	2641	2622
   q22	362	292	300	292
   Total cold run time: 44816 ms
   Total hot run time: 40009 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4401	4360	4391	4360
   q2	270	168	184	168
   q3	3547	3541	3517	3517
   q4	2377	2371	2362	2362
   q5	5723	5726	5716	5716
   q6	243	118	122	118
   q7	2367	1873	1906	1873
   q8	3495	3516	3520	3516
   q9	9040	9011	9012	9011
   q10	3913	3985	3993	3985
   q11	507	394	377	377
   q12	759	607	600	600
   q13	4303	3538	3564	3538
   q14	285	265	248	248
   q15	573	519	515	515
   q16	503	437	459	437
   q17	1860	1838	1854	1838
   q18	8679	8178	8263	8178
   q19	1706	1731	1780	1731
   q20	2251	1942	1934	1934
   q21	6521	6198	6167	6167
   q22	494	425	412	412
   Total cold run time: 63817 ms
   Total hot run time: 60601 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](table property) Fix table property `disable_auto_compaction` [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27853:
URL: https://github.com/apache/doris/pull/27853#issuecomment-1843287867

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 5befe5c090f0394706cba13f26a69241f8a5cb8c, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4733	4535	4450	4450
   q2	363	151	156	151
   q3	1444	1243	1210	1210
   q4	1126	961	943	943
   q5	3184	3176	3144	3144
   q6	252	128	128	128
   q7	1009	501	486	486
   q8	2195	2217	2186	2186
   q9	6667	6684	6685	6684
   q10	3211	3245	3273	3245
   q11	319	211	210	210
   q12	352	216	213	213
   q13	6310	3895	3758	3758
   q14	246	208	216	208
   q15	561	520	521	520
   q16	433	384	395	384
   q17	1009	601	592	592
   q18	7718	7116	7240	7116
   q19	1523	1344	1433	1344
   q20	521	351	329	329
   q21	3092	2704	2670	2670
   q22	357	291	295	291
   Total cold run time: 46625 ms
   Total hot run time: 40262 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4437	4432	4419	4419
   q2	267	163	171	163
   q3	3544	3524	3525	3524
   q4	2370	2376	2368	2368
   q5	5728	5751	5722	5722
   q6	238	124	122	122
   q7	2373	1855	1850	1850
   q8	3515	3512	3520	3512
   q9	9060	8980	9016	8980
   q10	3911	3991	4015	3991
   q11	505	364	382	364
   q12	769	592	579	579
   q13	4305	3542	3569	3542
   q14	295	261	254	254
   q15	575	522	514	514
   q16	504	471	443	443
   q17	1870	1846	1882	1846
   q18	8715	8266	8275	8266
   q19	1721	1749	1752	1749
   q20	2244	1939	1932	1932
   q21	6535	6170	6133	6133
   q22	504	420	430	420
   Total cold run time: 63985 ms
   Total hot run time: 60693 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org