You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Janne Jalkanen (JIRA)" <ji...@apache.org> on 2007/11/18 19:28:43 UTC

[jira] Created: (JSPWIKI-43) Template files should be placed under WEB-INF

Template files should be placed under WEB-INF
---------------------------------------------

                 Key: JSPWIKI-43
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-43
             Project: JSPWiki
          Issue Type: Improvement
          Components: Default template, Security
            Reporter: Janne Jalkanen
            Priority: Minor
             Fix For: 3.0


template JSPs and other JSPs not intended for direct access should be placed under WEB-INF.  This accomplishes two things

a) it stops annoying bots from accessing these pages directly (causing WikiContext may not be NULL messages in the logs)
b) it gives less vectors to potential harmful attacks.

However, this change is probably best done in 3.0 timeframe together with the move to Stripes.  Many things might break.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JSPWIKI-43) Template files should be placed under WEB-INF

Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JSPWIKI-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554968 ] 

Janne Jalkanen commented on JSPWIKI-43:
---------------------------------------

Hm.  There's a small problem though: all the icons and CSS files need to be in a browser-accessible directory, so doing this means that the templates can no longer be distributed as a single directory.  Which creates some overhead for admins and developers.

> Template files should be placed under WEB-INF
> ---------------------------------------------
>
>                 Key: JSPWIKI-43
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-43
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Authentication&Authorization, Default template
>            Reporter: Janne Jalkanen
>            Priority: Minor
>             Fix For: 3.0
>
>
> template JSPs and other JSPs not intended for direct access should be placed under WEB-INF.  This accomplishes two things
> a) it stops annoying bots from accessing these pages directly (causing WikiContext may not be NULL messages in the logs)
> b) it gives less vectors to potential harmful attacks.
> However, this change is probably best done in 3.0 timeframe together with the move to Stripes.  Many things might break.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JSPWIKI-43) Template files should be placed under WEB-INF

Posted by "Andrew Jaquith (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JSPWIKI-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546130 ] 

Andrew Jaquith commented on JSPWIKI-43:
---------------------------------------

Agreed. Let's park this until 3.0. It's a very good idea, though.

> Template files should be placed under WEB-INF
> ---------------------------------------------
>
>                 Key: JSPWIKI-43
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-43
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Authentication&Authorization, Default template
>            Reporter: Janne Jalkanen
>            Priority: Minor
>             Fix For: 3.0
>
>
> template JSPs and other JSPs not intended for direct access should be placed under WEB-INF.  This accomplishes two things
> a) it stops annoying bots from accessing these pages directly (causing WikiContext may not be NULL messages in the logs)
> b) it gives less vectors to potential harmful attacks.
> However, this change is probably best done in 3.0 timeframe together with the move to Stripes.  Many things might break.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JSPWIKI-43) Template files should be placed under WEB-INF

Posted by "Andrew Jaquith (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Jaquith closed JSPWIKI-43.
---------------------------------

    Resolution: Duplicate

See the other bug for more discussion...

> Template files should be placed under WEB-INF
> ---------------------------------------------
>
>                 Key: JSPWIKI-43
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-43
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Authentication&Authorization, Default template
>            Reporter: Janne Jalkanen
>            Priority: Minor
>             Fix For: 3.0
>
>
> template JSPs and other JSPs not intended for direct access should be placed under WEB-INF.  This accomplishes two things
> a) it stops annoying bots from accessing these pages directly (causing WikiContext may not be NULL messages in the logs)
> b) it gives less vectors to potential harmful attacks.
> However, this change is probably best done in 3.0 timeframe together with the move to Stripes.  Many things might break.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.