You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/03/09 03:16:14 UTC

Review Request: FLUME-1937: Issue with maxUnderReplication in HDFS sink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9838/
-----------------------------------------------------------

Review request for Flume.


Description
-------

maxUnderReplication is not respected


This addresses bug FLUME-1937.
    https://issues.apache.org/jira/browse/FLUME-1937


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java c11fb20 
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java c2b96f7 

Diff: https://reviews.apache.org/r/9838/diff/


Testing
-------

New unit test


Thanks,

Mike Percy


Re: Review Request: FLUME-1937: Issue with maxUnderReplication in HDFS sink

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9838/#review17643
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Alten-Lorenz


On March 9, 2013, 2:16 a.m., Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9838/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 2:16 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> maxUnderReplication is not respected
> 
> 
> This addresses bug FLUME-1937.
>     https://issues.apache.org/jira/browse/FLUME-1937
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java c11fb20 
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java c2b96f7 
> 
> Diff: https://reviews.apache.org/r/9838/diff/
> 
> 
> Testing
> -------
> 
> New unit test
> 
> 
> Thanks,
> 
> Mike Percy
> 
>


Re: Review Request: FLUME-1937: Issue with maxUnderReplication in HDFS sink

Posted by Will McQueen <wi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9838/#review17641
-----------------------------------------------------------

Ship it!


+1 lgtm

- Will McQueen


On March 9, 2013, 2:16 a.m., Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9838/
> -----------------------------------------------------------
> 
> (Updated March 9, 2013, 2:16 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> maxUnderReplication is not respected
> 
> 
> This addresses bug FLUME-1937.
>     https://issues.apache.org/jira/browse/FLUME-1937
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java c11fb20 
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java c2b96f7 
> 
> Diff: https://reviews.apache.org/r/9838/diff/
> 
> 
> Testing
> -------
> 
> New unit test
> 
> 
> Thanks,
> 
> Mike Percy
> 
>