You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/24 08:22:18 UTC

[GitHub] [flink] fapaul commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

fapaul commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r813634648



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -313,7 +329,14 @@ private void flushIfAble() {
      */
     private void flush() {
         while (inFlightRequestsCount >= maxInFlightRequests) {
-            mailboxExecutor.tryYield();
+            try {
+                mailboxExecutor.yield();
+            } catch (InterruptedException e) {

Review comment:
       Why do you handle the InterruptedException here? I think it is better to add it to the method signature because `write` allows throwing and `InterruptedException`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org