You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/11/11 04:34:32 UTC
[PR] [CELEBORN-1708] Bump protobuf from 3.21.7 to 3.25.5 [celeborn]
turboFei opened a new pull request, #2898:
URL: https://github.com/apache/celeborn/pull/2898
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2898:
URL: https://github.com/apache/celeborn/pull/2898#issuecomment-2467262702
the recent protobuf java versions introduced "runtime jar version" and "generated code version" check, it may affect the case: if we pull a thrid-party dependency that contains the generated protobuf code, we should be careful on bumping protobuf runtime jars version. For the Celeborn case, please also test Ratis gRPC mode when bumping protobuf versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2898:
URL: https://github.com/apache/celeborn/pull/2898#issuecomment-2467322915
it should has no issue if ratis uses a shaded protobuf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2898:
URL: https://github.com/apache/celeborn/pull/2898#issuecomment-2467378167
Flaky test: PushDataTimeoutTest
https://github.com/apache/celeborn/actions/runs/11773080253/job/32789461415?pr=2898
```
[info] org.apache.celeborn.tests.spark.PushDataTimeoutTest *** ABORTED ***
[info] java.lang.AssertionError: assertion failed
[info] at scala.Predef$.assert(Predef.scala:208)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.$anonfun$setUpWorkers$7(MiniClusterFeature.scala:234)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.$anonfun$setUpWorkers$7$adapted(MiniClusterFeature.scala:234)
[info] at scala.collection.mutable.HashMap.$anonfun$foreach$1(HashMap.scala:149)
[info] at scala.collection.mutable.HashTable.foreachEntry(HashTable.scala:237)
[info] at scala.collection.mutable.HashTable.foreachEntry$(HashTable.scala:230)
[info] at scala.collection.mutable.HashMap.foreachEntry(HashMap.scala:44)
[info] at scala.collection.mutable.HashMap.foreach(HashMap.scala:149)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setUpWorkers(MiniClusterFeature.scala:234)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setUpWorkers$(MiniClusterFeature.scala:181)
[info] at org.apache.celeborn.tests.spark.PushDataTimeoutTest.setUpWorkers(PushDataTimeoutTest.scala:34)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setUpMiniCluster(MiniClusterFeature.scala:254)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setUpMiniCluster$(MiniClusterFeature.scala:250)
[info] at org.apache.celeborn.tests.spark.PushDataTimeoutTest.setUpMiniCluster(PushDataTimeoutTest.scala:34)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setupMiniClusterWithRandomPorts(MiniClusterFeature.scala:77)
[info] at org.apache.celeborn.service.deploy.MiniClusterFeature.setupMiniClusterWithRandomPorts$(MiniClusterFeature.scala:49)
[info] at org.apache.celeborn.tests.spark.PushDataTimeoutTest.setupMiniClusterWithRandomPorts(PushDataTimeoutTest.scala:34)
[info] at org.apache.celeborn.tests.spark.PushDataTimeoutTest.beforeAll(PushDataTimeoutTest.scala:47)
[info] at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:212)
[info] at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
[info] at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
[info] at org.apache.celeborn.tests.spark.PushDataTimeoutTest.run(PushDataTimeoutTest.scala:34)
[info] at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:321)
[info] at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:517)
[info] at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:414)
[info] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[info] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[info] at java.lang.Thread.run(Thread.java:750)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2898:
URL: https://github.com/apache/celeborn/pull/2898#issuecomment-2467277345
For ratis:
The `shaded.protobuf.version` is 3.24.4 in ratis 3.1.1 and 3.1.2
https://github.com/apache/ratis/blob/45a30d890451a44ec918fdee2732c5fff80ea17c/pom.xml#L216C1-L217C1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2898: [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5
URL: https://github.com/apache/celeborn/pull/2898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2898:
URL: https://github.com/apache/celeborn/pull/2898#issuecomment-2467311483
@pan3793 how about adding the UT with grpc mode?
The protobuf is shaded and the shaded.protobuf.version is 3.24.4 in ratis 3.1.1 and 3.1.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org