You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/09/24 10:00:46 UTC

[GitHub] [rocketmq] mickey0524 opened a new issue #1481: logging 包代码多余

mickey0524 opened a new issue #1481: logging 包代码多余
URL: https://github.com/apache/rocketmq/issues/1481
 
 
   logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java 文件中 284 行的判断是多余的，如果前面的 for 循环结束，说明 len == argArray.length，或者直接在 for 循环内就 return 了，因此此处没有必要使用 if
   <img width="775" alt="rocketmq-log" src="https://user-images.githubusercontent.com/22164927/65502296-1c05b280-def5-11e9-9b9b-4cb6b1f19f08.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services