[GitHub] [cloudstack] ggoodrich-ipp commented on a change in pull request #4266: Adding os type id to the usage record response for virtual machines

[GitBox <gi...@apache.org>]

ggoodrich-ipp commented on a change in pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#discussion_r588354445



##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -3386,6 +3386,7 @@ public UsageRecordResponse createUsageResponse(Usage usageRecord, Map<String, Se
                 resourceType = ResourceTag.ResourceObjectType.UserVm;
                 usageRecResponse.setUsageId(vm.getUuid());
                 resourceId = vm.getId();
+                usageRecResponse.setOsTypeId(vm.getGuestOSId());

Review comment:
       I guess I must've realized this, as I'm storing this off as an int in a local billing database. Is it an easy fix to change this to get the UUID? It appears where I'm using it, I fetch this int value, and then use it to go get the UUID, so it seems the UUID is ultimately what I need. Maybe I used the int as that was already in the model? It has been far enough back that I don't recall the specifics.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org