You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2023/05/23 13:17:23 UTC
[Impala-ASF-CR] IMPALA-12158: Fixed alert in bin/coverage helper.sh
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19917
Change subject: IMPALA-12158: Fixed alert in bin/coverage_helper.sh
......................................................................
IMPALA-12158: Fixed alert in bin/coverage_helper.sh
IMPALA-10794 introduced names for threads, which messed up process names
too in catalogd and impalad. By default, pgrep matches the search string
only on the process name, with -f it will look into the program's path
too, so it can alert about still running impalad (and not saved coverage
counters).
Testing:
- Tested locally
Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
---
M bin/coverage_helper.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19917/1
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has abandoned this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
Abandoned
Fixed in https://gerrit.cloudera.org/#/c/19990/
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13106/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 14:54:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
IMPALA-12158: Added -f to "pgrep impalad" commands
IMPALA-10794 introduced names for threads, which messed up process names
too for catalogd and impalad.
By default, pgrep matches the search string only on the process name,
with -f it will look into the program's path as well.
My testing showed it only happens in local catalog mode, so not all
pgrep calls were broken (e.g. graceful shutdown test was passing, but
the script does nothing if I start the cluster with local catalog mode).
I think it is safer to add -f everywhere.
Testing:
- Tested locally with bin/coverage_report.sh and
bin/graceful_shutdown_backends.sh
Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
---
M bin/coverage_helper.sh
M bin/dump-stacktraces.sh
M bin/graceful_shutdown_backends.sh
M tests/common/impala_service.py
M tests/comparison/cluster.py
M tests/query_test/test_tablesample.py
6 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19917/3
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12158: Fixed alert in bin/coverage helper.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Fixed alert in bin/coverage_helper.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9340/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 13:29:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
IMPALA-12158: Added -f to "pgrep impalad" commands
IMPALA-10794 introduced names for threads, which messed up process names
too in catalogd and impalad.
By default, pgrep matches the search string only on the process name,
with -f it will look into the program's path too.
My testing showed it only happens in local catalog mode, so not all
pgrep calls were broken (e.g. graceful shutdown test was passing, but
the script does nothing if I start the cluster with local catalog mode).
I think it is safer to add -f everywhere.
Testing:
- Tested locally with bin/coverage_report.sh and
bin/graceful_shutdown_backends.sh
Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
---
M bin/coverage_helper.sh
M bin/dump-stacktraces.sh
M bin/graceful_shutdown_backends.sh
M tests/common/impala_service.py
M tests/comparison/cluster.py
M tests/query_test/test_tablesample.py
6 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19917/2
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13105/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 14:52:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12158: Fixed alert in bin/coverage helper.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Fixed alert in bin/coverage_helper.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13104/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 13:38:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12158: Fixed alert in bin/coverage helper.sh
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Fixed alert in bin/coverage_helper.sh
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 13:21:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19917 )
Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19917/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19917/3//COMMIT_MSG@9
PS3, Line 9: IMPALA-10794 introduced names for threads, which messed up process names
I'd prefer all the process names were descriptive. Is there no way to fix that?
http://gerrit.cloudera.org:8080/#/c/19917/3//COMMIT_MSG@13
PS3, Line 13: with -f it will look into the program's path as well.
This could get false-positives if your development environment includes "impala" in a directory name.
--
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 May 2023 18:14:19 +0000
Gerrit-HasComments: Yes