You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2007/07/10 16:38:05 UTC

[jira] Created: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

ability to update openejb-jar.xml by examining annotations
----------------------------------------------------------

                 Key: GERONIMO-3304
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
             Project: Geronimo
          Issue Type: New Feature
      Security Level: public (Regular issues)
          Components: J2G
         Environment: windows xp, linux
            Reporter: Viet Hung Nguyen


As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3304:
---------------------------------------

    Attachment: geronimo-3304-4.patch

I did everything from the latest src actually. I tested it on my windows machine before posting it and tested it on a linux machine via ssh. But I got jason warner to test it on his machine and it failed. Once again, thanks to jason for copying the patch line by line into j2g's source to make an applyable patch.

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304-2.patch, geronimo-3304-3.patch, geronimo-3304-4.patch, geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3304:
---------------------------------------

    Attachment: geronimo-3304-2.patch

I have added more useful comments when the user is using J2G. Additionally, I have taken out some of the unnecessary comments. 

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304-2.patch, geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3304:
---------------------------------------

    Attachment: geronimo-3304.patch

this patch updates (under certain circumstances creates) openejb-jar.xml by looking at the annotations, and updates as much of the DD as possible. 

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Paul McMahan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512277 ] 

Paul McMahan commented on GERONIMO-3304:
----------------------------------------

is your src current?  when I try to apply the patch I get:

patching file plugins/org.apache.geronimo.j2g.descriptors/src/org/apache/geronimo/j2g/descriptors/ejb/annotation/AnnotationTool.java
Hunk #2 FAILED at 39.
Hunk #3 succeeded at 63 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file plugins/org.apache.geronimo.j2g.descriptors/src/org/apache/geronimo/j2g/descriptors/ejb/annotation/AnnotationTool.java.rej
patching file plugins/org.apache.geronimo.j2g.descriptors/src/org/apache/geronimo/j2g/descriptors/ejb/EJBDescriptorTool.java
Hunk #1 succeeded at 82 (offset -9 lines).

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304-2.patch, geronimo-3304-3.patch, geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Paul McMahan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul McMahan resolved GERONIMO-3304.
------------------------------------

    Resolution: Fixed
      Assignee: Paul McMahan

thanks!   Committed revision 556157.

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>            Assignee: Paul McMahan
>         Attachments: geronimo-3304-2.patch, geronimo-3304-3.patch, geronimo-3304-4.patch, geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511497 ] 

Matt Hogstrom commented on GERONIMO-3304:
-----------------------------------------

You might look at DayTrader as it has jboss DDs in it.  Look here for the current DT source:

https://svn.apache.org/repos/asf/geronimo/daytrader/trunk

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3304) ability to update openejb-jar.xml by examining annotations

Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Viet Hung Nguyen updated GERONIMO-3304:
---------------------------------------

    Attachment: geronimo-3304-3.patch

this patch warns users if the source code contains references to JBoss's extension to EJB annotations.

> ability to update openejb-jar.xml by examining annotations
> ----------------------------------------------------------
>
>                 Key: GERONIMO-3304
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3304
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: J2G
>         Environment: windows xp, linux
>            Reporter: Viet Hung Nguyen
>         Attachments: geronimo-3304-2.patch, geronimo-3304-3.patch, geronimo-3304.patch
>
>
> As of now, when there is a jboss.xml in a JBoss project, the geronimo equivalent is written to openejb-jar.xml. However, that only covers EJB 2.1's features. We need a way to update the openejb-jar.xml by looking at the annotations because there is still some configuring left to do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.